maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Alerts] Hide case connector (#85398)

Browse source 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Christos Nasikas 2020-12-09 21:38:41 +02:00 committed by GitHub
parent 90893f9487
commit 8b5c68ab63
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 27 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/action_type_menu.tsx
View file

@ -12,6 +12,7 @@ import { loadActionTypes } from '../../lib/action_connector_api';
import { actionTypeCompare } from '../../lib/action_type_compare';
import { checkActionTypeEnabled } from '../../lib/check_action_type_enabled';
import { useKibana } from '../../../common/lib/kibana';
import { DEFAULT_HIDDEN_ACTION_TYPES } from '../../..';
interface Props {
onActionTypeChange: (actionType: ActionType) => void;
@ -35,7 +36,18 @@ export const ActionTypeMenu = ({
useEffect(() => {
(async () => {
try {
const availableActionTypes = actionTypes ?? (await loadActionTypes({ http }));
/**
* Hidden action types will be hidden only on Alerts & Actions.
* actionTypes prop is not filtered. Thus, any consumer that provides it's own actionTypes
* can use the hidden action types. For example, Cases or Detections of Security Solution.
*
* TODO: Remove when cases connector is available across Kibana. Issue: https://github.com/elastic/kibana/issues/82502.
* */
const availableActionTypes =
actionTypes ??
(await loadActionTypes({ http })).filter(
(actionType) => !DEFAULT_HIDDEN_ACTION_TYPES.includes(actionType.id)
);
const index: ActionTypeIndex = {};
for (const actionTypeItem of availableActionTypes) {
index[actionTypeItem.id] = actionTypeItem;

22
x-pack/plugins/triggers_actions_ui/public/application/sections/actions_connectors_list/components/actions_connectors_list.tsx
View file

@ -39,6 +39,7 @@ import './actions_connectors_list.scss';
import { ActionConnector, ActionConnectorTableItem, ActionTypeIndex } from '../../../../types';
import { EmptyConnectorsPrompt } from '../../../components/prompts/empty_connectors_prompt';
import { useKibana } from '../../../../common/lib/kibana';
import { DEFAULT_HIDDEN_ACTION_TYPES } from '../../../../';
export const ActionsConnectorsList: React.FunctionComponent = () => {
const {
@ -94,18 +95,23 @@ export const ActionsConnectorsList: React.FunctionComponent = () => {
}, []);
const actionConnectorTableItems: ActionConnectorTableItem[] = actionTypesIndex
? actions.map((action) => {
return {
...action,
actionType: actionTypesIndex[action.actionTypeId]
? actionTypesIndex[action.actionTypeId].name
: action.actionTypeId,
};
})
? actions
// TODO: Remove when cases connector is available across Kibana. Issue: https://github.com/elastic/kibana/issues/82502.
.filter((action) => !DEFAULT_HIDDEN_ACTION_TYPES.includes(action.actionTypeId))
.map((action) => {
return {
...action,
actionType: actionTypesIndex[action.actionTypeId]
? actionTypesIndex[action.actionTypeId].name
: action.actionTypeId,
};
})
: [];
const actionTypesList: Array<{ value: string; name: string }> = actionTypesIndex
? Object.values(actionTypesIndex)
// TODO: Remove when cases connector is available across Kibana. Issue: https://github.com/elastic/kibana/issues/82502.
.filter((actionType) => !DEFAULT_HIDDEN_ACTION_TYPES.includes(actionType.id))
.map((actionType) => ({
value: actionType.id,
name: `${actionType.name} (${getActionsCountByActionType(actions, actionType.id)})`,