maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix inaccurate Kibana status message when Kibana is in a yellow "degraded" state (#103816)

Browse source 
* Correctly orders imports via ESLint

* Accounts for "yellow" status

We should do much better than this.
a) We shouldn't be converting the statuses to colors in the first place
b) We shouldn't always show the same message for all non-green statuses
c) We shouldn't link to kibana status when we are the kibana monitoring product
This commit is contained in:
Jason Rhodes 2021-06-30 12:45:59 -04:00 committed by GitHub
parent ffc207281f
commit 8c34a88d26
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
x-pack/plugins/monitoring/public/components/cluster/overview/helpers.js
View file

@ -5,20 +5,21 @@
* 2.0.
*/
import React from 'react';
import {
EuiFlexGroup,
EuiFlexItem,
EuiHealth,
EuiIcon,
EuiLink,
EuiSpacer,
EuiText,
EuiTitle,
} from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import { get } from 'lodash';
import { formatBytesUsage, formatPercentageUsage, formatNumber } from '../../../lib/format_number';
import {
EuiSpacer,
EuiFlexItem,
EuiFlexGroup,
EuiTitle,
EuiIcon,
EuiHealth,
EuiText,
EuiLink,
} from '@elastic/eui';
import React from 'react';
import { Legacy } from '../../../legacy_shims';
import { formatBytesUsage, formatNumber, formatPercentageUsage } from '../../../lib/format_number';
export function HealthLabel(props) {
if (props.status === 'green') {
@ -42,15 +43,14 @@ export function HealthLabel(props) {
}
}
if (product === 'kb' && status === 'red') {
// TODO: Use the actual service level statuses instead of converting them to colors
if (product === 'kb' && (status === 'yellow' || status === 'red')) {
return (
<EuiText>
{i18n.translate('xpack.monitoring.cluster.health.pluginIssues', {
defaultMessage: 'Some plugins are experiencing issues. Check ',
defaultMessage: 'Some plugins may be experiencing issues. Please check ',
})}
<EuiLink href="/status" target="_blank" external={true}>
status
</EuiLink>
<EuiLink href={`${Legacy.shims.getBasePath()}/status`}>the Kibana status page</EuiLink>.
</EuiText>
);
}