maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Move isImmutableConfig to a utility file

Browse source 
And test it.
This commit is contained in:
Court Ewing 2015-09-11 13:54:27 -04:00
parent 120a2a7f54
commit 8c49d4f879
3 changed files with 34 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/plugins/kibana/public/settings/__tests__/is_immutable_config.js Normal file
View file

@ -0,0 +1,17 @@
var isImmutableConfig = require('plugins/kibana/settings/sections/advanced/lib/is_immutable_config');
var expect = require('expect.js');
describe('Settings', function () {
describe('Advanced', function () {
describe('isImmutableConfig(configName)', function () {
it('returns true given an immutable field name', function () {
expect(isImmutableConfig('buildNum')).to.be.true;
});
it('returns false given any value that does not match the whitelist', function () {
expect(isImmutableConfig('something else')).to.be.false;
});
});
});
});

8
src/plugins/kibana/public/settings/sections/advanced/index.js
View file

@ -1,6 +1,8 @@
define(function (require) {
var _ = require('lodash');
var toEditableConfig = require('plugins/kibana/settings/sections/advanced/lib/to_editable_config');
var isImmutableConfig = require('plugins/kibana/settings/sections/advanced/lib/is_immutable_config');
var notImmutableConfig = _.negate(isImmutableConfig);
require('plugins/kibana/settings/sections/advanced/advanced_row');
@ -20,8 +22,6 @@ define(function (require) {
ESC: 27
};
var IMMUTABLE_CONFIG_VALS = ['buildNum'];
function isTypeComplex(conf) {
return !(conf.json || conf.array || conf.bool || conf.normal);
}
@ -30,10 +30,6 @@ define(function (require) {
return !(configName in configDefaults);
}
function notImmutableConfig(configName) {
return !_.contains(IMMUTABLE_CONFIG_VALS, configName);
}
function readConfigVals() {
var configVals = config._vals();

15
src/plugins/kibana/public/settings/sections/advanced/lib/is_immutable_config.js Normal file
View file

@ -0,0 +1,15 @@
define(function (require) {
var _ = require('lodash');
var IMMUTABLE_CONFIG_VALS = ['buildNum'];
/**
* @param {string} name of configuration
* @returns {boolean} whether the given name matches an immutable field name
*/
function isImmutableConfig(configName) {
return _.contains(IMMUTABLE_CONFIG_VALS, configName);
}
return isImmutableConfig;
});