maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Lens] Make Lens plugin registry signatures consistent (#51839)

Browse source
This commit is contained in:
Chris Davies 2019-12-04 08:36:21 -05:00 committed by GitHub
parent 529dcbbe30
commit 8cae172f02
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
x-pack/legacy/plugins/lens/public/app_plugin/plugin.tsx
View file

@ -73,7 +73,7 @@ export class AppPlugin {
editorFrameSetupInterface.registerVisualization(xyVisualization);
editorFrameSetupInterface.registerVisualization(datatableVisualization);
editorFrameSetupInterface.registerVisualization(metricVisualization);
editorFrameSetupInterface.registerDatasource('indexpattern', indexPattern);
editorFrameSetupInterface.registerDatasource(indexPattern);
kibana_legacy.registerLegacyApp({
id: 'lens',

1
x-pack/legacy/plugins/lens/public/editor_frame_plugin/mocks.tsx
View file

@ -51,6 +51,7 @@ export function createMockDatasource(): DatasourceMock {
};
return {
id: 'mockindexpattern',
getDatasourceSuggestionsForField: jest.fn((_state, item) => []),
getDatasourceSuggestionsFromCurrentState: jest.fn(_state => []),
getPersistableState: jest.fn(),

4
x-pack/legacy/plugins/lens/public/editor_frame_plugin/plugin.tsx
View file

@ -57,8 +57,8 @@ export class EditorFramePlugin {
plugins.expressions.registerFunction(() => mergeTables);
return {
registerDatasource: (name, datasource) => {
this.datasources[name] = datasource as Datasource<unknown, unknown>;
registerDatasource: datasource => {
this.datasources[datasource.id] = datasource as Datasource<unknown, unknown>;
},
registerVisualization: visualization => {
this.visualizations[visualization.id] = visualization as Visualization<unknown, unknown>;

2
x-pack/legacy/plugins/lens/public/indexpattern_plugin/indexpattern.tsx
View file

@ -113,6 +113,8 @@ export function getIndexPatternDatasource({
// Not stateful. State is persisted to the frame
const indexPatternDatasource: Datasource<IndexPatternPrivateState, IndexPatternPersistedState> = {
id: 'indexpattern',
initialize(state?: IndexPatternPersistedState) {
return loadInitialState({ state, savedObjectsClient });
},

4
x-pack/legacy/plugins/lens/public/types.ts
View file

@ -47,7 +47,7 @@ export interface EditorFrameInstance {
export interface EditorFrameSetup {
// generic type on the API functions to pull the "unknown vs. specific type" error into the implementation
registerDatasource: <T, P>(name: string, datasource: Datasource<T, P>) => void;
registerDatasource: <T, P>(datasource: Datasource<T, P>) => void;
registerVisualization: <T, P>(visualization: Visualization<T, P>) => void;
}
@ -123,6 +123,8 @@ export type StateSetter<T> = (newState: T | ((prevState: T) => T)) => void;
* Interface for the datasource registry
*/
export interface Datasource<T = unknown, P = unknown> {
id: string;
// For initializing, either from an empty state or from persisted state
// Because this will be called at runtime, state might have a type of `any` and
// datasources should validate their arguments