maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Removes support for unused optimize.* settings from core deprecations (#113296)

Browse source 
Co-authored-by: Luke Elmers <lukeelmers@gmail.com>
This commit is contained in:
Christiane (Tina) Heiligers 2021-09-28 13:08:52 -07:00 committed by GitHub
parent 4fe8605c7b
commit 8d8b40075e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 40 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
docs/migration/migrate_8_0.asciidoc
View file

@ -259,6 +259,12 @@ URL that it derived from the actual server address and `xpack.security.public` s
*Impact:* Any workflow that involved manually clearing generated bundles will have to be updated with the new path.
[float]
=== Legacy `optimize.*` settings are no longer supported
*Details:* The legacy optimizer has been removed and any `optimize.*` settings have been deprecated since 7.10. These settings have been removed as they are no longer in use.
*Impact:* Any of the legacy `optimize.*` settings will prevent Kibana from starting up. Going forward, to run the `@kbn/optimizer` separately in development, pass `--no-optimizer` to `yarn start`. See https://github.com/elastic/kibana/pull/73154 for more details.
[float]
=== kibana.keystore has moved from the `data` folder to the `config` folder
*Details:* By default, kibana.keystore has moved from the configured `path.data` folder to `<root>/config` for archive distributions

19
src/core/server/config/deprecation/core_deprecations.ts
View file

@ -353,25 +353,6 @@ const logFilterDeprecation: ConfigDeprecation = (settings, fromPath, addDeprecat
};
export const coreDeprecationProvider: ConfigDeprecationProvider = ({ rename, unusedFromRoot }) => [
unusedFromRoot('optimize.lazy'),
unusedFromRoot('optimize.lazyPort'),
unusedFromRoot('optimize.lazyHost'),
unusedFromRoot('optimize.lazyPrebuild'),
unusedFromRoot('optimize.lazyProxyTimeout'),
unusedFromRoot('optimize.enabled'),
unusedFromRoot('optimize.bundleFilter'),
unusedFromRoot('optimize.bundleDir'),
unusedFromRoot('optimize.viewCaching'),
unusedFromRoot('optimize.watch'),
unusedFromRoot('optimize.watchPort'),
unusedFromRoot('optimize.watchHost'),
unusedFromRoot('optimize.watchPrebuild'),
unusedFromRoot('optimize.watchProxyTimeout'),
unusedFromRoot('optimize.useBundleCache'),
unusedFromRoot('optimize.sourceMaps'),
unusedFromRoot('optimize.workers'),
unusedFromRoot('optimize.profile'),
unusedFromRoot('optimize.validateSyntaxOfNodeModules'),
rename('cpu.cgroup.path.override', 'ops.cGroupOverrides.cpuPath'),
rename('cpuacct.cgroup.path.override', 'ops.cGroupOverrides.cpuAcctPath'),
rename('server.xsrf.whitelist', 'server.xsrf.allowlist'),

21
src/core/server/config/integration_tests/config_deprecation.test.ts
View file

@ -36,25 +36,4 @@ describe('configuration deprecations', () => {
]
`);
});
it('should log deprecation warnings for core deprecations', async () => {
root = kbnTestServer.createRoot({
optimize: {
lazy: true,
lazyPort: 9090,
},
});
await root.preboot();
await root.setup();
const logs = loggingSystemMock.collect(mockLoggingSystem);
expect(logs.warn.flat()).toMatchInlineSnapshot(`
Array [
"You no longer need to configure \\"optimize.lazy\\".",
"You no longer need to configure \\"optimize.lazyPort\\".",
"\\"logging.silent\\" has been deprecated and will be removed in 8.0. Moving forward, you can use \\"logging.root.level:off\\" in your logging configuration. ",
]
`);
});
});