New platform cleanup autoload - step 1 (#33765)

* Explicit dependencies to doc_title

* Explicit dependencies to
    - kbn_top_nav
    - saved_object_save_as_checkbox

* Explicit dependencies to filter_bar

* Explicit dependency to query_bar

* Removed modules from autoloades that never
used implicitly:
- bound_to_config_obj
- debounce
- filter_manager
- index_patterns
- parse_query
- persisted_log
- timefilter

* Removed modules from autoload (never used implicitly)
- events

* Explicit dependency to bind + typo fix

* Explicit dependency to fancy_forms

* Explicit dependency to $listen

* Explicit dependency to timepicker

* Moved kbn-infinite-scroll directive to doc_table

* Explicit dependency on directives
- css truncate
- inequality

* Explicit dependecy to input_focus directive

* Explicit dependency to json-input directive

* Explicit dependency on directives:
 - input_focus
 - paginate

* Explicit dependency on paginated-selectable-list directive

* Explicit dependency on saved-object-finder directive

* Moved validate_json directive into agg_types

* Don't include directives implicitly

src/legacy/core_plugins/console/public/src/controllers/sense_controller.js

@@ -16,7 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import 'ui/doc_title';
+import { DocTitleProvider } from 'ui/doc_title';
 import { applyResizeCheckerToEditors } from '../sense_editor_resize';
 import $ from 'jquery';
 import { initializeInput } from '../input';
@@ -34,7 +34,8 @@ module.run(function (Private, $rootScope) {
   };
 });
 
-module.controller('SenseController', function SenseController(Private, $scope, $timeout, $location, docTitle, kbnUiAceKeyboardModeService) {
+module.controller('SenseController', function SenseController(Private, $scope, $timeout, $location, kbnUiAceKeyboardModeService) {
+  const docTitle = Private(DocTitleProvider);
   docTitle.change('Console');
 
   $scope.topNavController = Private(SenseTopNavController);

src/legacy/core_plugins/kibana/public/context/index.js

@@ -20,6 +20,7 @@
 import _ from 'lodash';
 
 import { FilterBarQueryFilterProvider } from 'ui/filter_bar/query_filter';
+import 'ui/listen';
 import uiRoutes from 'ui/routes';
 import { i18n } from '@kbn/i18n';
 

src/legacy/core_plugins/kibana/public/dashboard/dashboard_app.js

@@ -25,6 +25,7 @@ import chrome from 'ui/chrome';
 import { wrapInI18nContext } from 'ui/i18n';
 import { toastNotifications } from 'ui/notify';
 
+import 'ui/listen';
 import 'ui/search_bar';
 import 'ui/apply_filters';
 

src/legacy/core_plugins/kibana/public/dashboard/dashboard_state_manager.js

@@ -290,7 +290,7 @@ export class DashboardStateManager {
    * Resets the state back to the last saved version of the dashboard.
    */
   resetState() {
-    // In order to show the correct warning for the saved-object-save-as-check-box we have to store the unsaved
+    // In order to show the correct warning, we have to store the unsaved
     // title on the dashboard object. We should fix this at some point, but this is how all the other object
     // save panels work at the moment.
     this.savedDashboard.title = this.savedDashboard.lastSavedTitle;
@@ -341,9 +341,6 @@ export class DashboardStateManager {
 
   setTitle(title) {
     this.appState.title = title;
-    // The saved-object-save-as-check-box shows a warning if the current object title is different then
-    // the existing object title. It calculates this difference by comparing this.dashboard.title to
-    // this.dashboard.lastSavedTitle, so we need to push the temporary, unsaved title, onto the dashboard.
     this.savedDashboard.title = title;
     this.saveState();
   }

src/legacy/core_plugins/kibana/public/dashboard/index.js

@@ -22,6 +22,7 @@ import './saved_dashboard/saved_dashboards';
 import './dashboard_config';
 import uiRoutes from 'ui/routes';
 import chrome from 'ui/chrome';
+import 'ui/filter_bar';
 import { wrapInI18nContext } from 'ui/i18n';
 import { toastNotifications } from 'ui/notify';
 

src/legacy/core_plugins/kibana/public/dev_tools/directives/dev_tools_app.js

@@ -20,7 +20,6 @@
 import { uiModules } from 'ui/modules';
 import { DevToolsRegistryProvider } from 'ui/registry/dev_tools';
 import template from '../partials/dev_tools_app.html';
-import 'ui/kbn_top_nav';
 
 uiModules
   .get('apps/dev_tools')

src/legacy/core_plugins/kibana/public/dev_tools/index.js

@@ -20,6 +20,7 @@
 import uiRoutes from 'ui/routes';
 import { DevToolsRegistryProvider } from 'ui/registry/dev_tools';
 import { FeatureCatalogueRegistryProvider, FeatureCatalogueCategory } from 'ui/registry/feature_catalogue';
+import 'ui/directives/kbn_href';
 import './directives/dev_tools_app';
 
 uiRoutes

src/legacy/core_plugins/kibana/public/discover/controllers/discover.js

@@ -26,6 +26,7 @@ import * as columnActions from 'ui/doc_table/actions/columns';
 import * as filterActions from 'ui/doc_table/actions/filter';
 import dateMath from '@elastic/datemath';
 import 'ui/doc_table';
+import 'ui/listen';
 import 'ui/visualize';
 import 'ui/fixed_scroll';
 import 'ui/filters/moment';

src/legacy/core_plugins/kibana/public/kibana.js

@@ -47,6 +47,7 @@ import 'uiExports/autocompleteProviders';
 import 'uiExports/shareContextMenuExtensions';
 
 import 'ui/autoload/all';
+import 'ui/kbn_top_nav';
 import './home';
 import './discover';
 import './visualize';

src/legacy/core_plugins/kibana/public/management/index.js

@@ -33,7 +33,6 @@ import { management, SidebarNav, MANAGEMENT_BREADCRUMB } from 'ui/management';
 import { FeatureCatalogueRegistryProvider, FeatureCatalogueCategory } from 'ui/registry/feature_catalogue';
 import { timefilter } from 'ui/timefilter';
 import { EuiPageContent, EuiTitle, EuiText, EuiSpacer, EuiIcon, EuiHorizontalRule } from '@elastic/eui';
-import 'ui/kbn_top_nav';
 
 const SIDENAV_ID = 'management-sidenav';
 const LANDING_ID = 'management-landing';

src/legacy/core_plugins/kibana/public/management/sections/index_patterns/edit_index_pattern/create_edit_field/create_edit_field.js

@@ -19,6 +19,7 @@
 
 import { Field } from 'ui/index_patterns/_field';
 import { RegistryFieldFormatEditorsProvider } from 'ui/registry/field_format_editors';
+import { DocTitleProvider } from 'ui/doc_title';
 import { KbnUrlProvider } from 'ui/url';
 import uiRoutes from 'ui/routes';
 import { toastNotifications } from 'ui/notify';
@@ -101,8 +102,9 @@ uiRoutes
       }
     },
     controllerAs: 'fieldSettings',
-    controller: function FieldEditorPageController($scope, $route, $timeout, $http, Private, docTitle, config) {
+    controller: function FieldEditorPageController($scope, $route, $timeout, $http, Private, config) {
       const getConfig = (...args) => config.get(...args);
+      const docTitle = Private(DocTitleProvider);
       const fieldFormatEditors = Private(RegistryFieldFormatEditorsProvider);
       const kbnUrl = Private(KbnUrlProvider);
 

src/legacy/core_plugins/kibana/public/management/sections/index_patterns/edit_index_pattern/edit_index_pattern.js

@@ -20,6 +20,7 @@
 import _ from 'lodash';
 import './index_header';
 import './create_edit_field';
+import { DocTitleProvider } from 'ui/doc_title';
 import { KbnUrlProvider } from 'ui/url';
 import { IndicesEditSectionsProvider } from './edit_sections';
 import { fatalError, toastNotifications } from 'ui/notify';
@@ -170,7 +171,7 @@ uiRoutes
 
 uiModules.get('apps/management')
   .controller('managementIndexPatternsEdit', function (
-    $scope, $location, $route, config, indexPatterns, Private, AppState, docTitle, confirmModal) {
+    $scope, $location, $route, config, indexPatterns, Private, AppState, confirmModal) {
     const $state = $scope.state = new AppState();
     const { fieldWildcardMatcher } = Private(FieldWildcardProvider);
     const indexPatternListProvider = Private(IndexPatternListFactory)();
@@ -182,6 +183,7 @@ uiModules.get('apps/management')
     $scope.indexPatternListProvider = indexPatternListProvider;
     $scope.indexPattern.tags = indexPatternListProvider.getIndexPatternTags($scope.indexPattern);
     $scope.getFieldInfo = indexPatternListProvider.getFieldInfo;
+    const docTitle = Private(DocTitleProvider);
     docTitle.change($scope.indexPattern.title);
 
     const otherPatterns = _.filter($route.current.locals.indexPatterns, pattern => {

src/legacy/core_plugins/kibana/public/visualize/editor/editor.js

@@ -25,6 +25,7 @@ import 'ui/visualize';
 import 'ui/collapsible_sidebar';
 import 'ui/search_bar';
 import 'ui/apply_filters';
+import 'ui/listen';
 import chrome from 'ui/chrome';
 import React from 'react';
 import angular from 'angular';

src/legacy/core_plugins/kibana/public/visualize/index.js

@@ -24,6 +24,7 @@ import 'ui/draggable/draggable_handle';
 import './saved_visualizations/_saved_vis';
 import './saved_visualizations/saved_visualizations';
 import 'ui/filters/sort_prefix_first';
+import 'ui/filter_bar';
 import uiRoutes from 'ui/routes';
 import visualizeListingTemplate from './listing/visualize_listing.html';
 import { VisualizeListingController } from './listing/visualize_listing';

src/legacy/core_plugins/kibana/public/visualize/listing/visualize_listing.js

@@ -20,6 +20,7 @@
 import { SavedObjectRegistryProvider } from 'ui/saved_objects/saved_object_registry';
 import 'ui/pager_control';
 import 'ui/pager';
+import 'ui/directives/kbn_href';
 import { uiModules } from 'ui/modules';
 import { timefilter } from 'ui/timefilter';
 import { VisTypesRegistryProvider } from 'ui/registry/vis_types';

src/legacy/core_plugins/metric_vis/public/metric_vis_params.js

@@ -18,6 +18,7 @@
  */
 
 import { uiModules } from 'ui/modules';
+import 'ui/directives/inequality';
 import metricVisParamsTemplate from './metric_vis_params.html';
 import _ from 'lodash';
 const module = uiModules.get('kibana');

src/legacy/core_plugins/timelion/public/app.js

@@ -32,6 +32,14 @@ import 'uiExports/fieldFormats';
 import 'uiExports/savedObjectTypes';
 
 require('ui/autoload/all');
+
+// TODO: remove ui imports completely (move to plugins)
+import 'ui/directives/input_focus';
+import 'ui/directives/saved_object_finder';
+import 'ui/listen';
+import 'ui/kbn_top_nav';
+import 'ui/saved_objects/ui/saved_object_save_as_checkbox';
+
 require('plugins/timelion/directives/cells/cells');
 require('plugins/timelion/directives/fixed_element');
 require('plugins/timelion/directives/fullscreen/fullscreen');

src/legacy/ui/public/autoload/all.js

@@ -19,7 +19,6 @@
 
 import './accessibility';
 import './modules';
-import './directives';
 import './filters';
 import './settings';
 import './styles';

src/legacy/ui/public/autoload/directives.js

@@ -1,21 +0,0 @@
-/*
- * Licensed to Elasticsearch B.V. under one or more contributor
- * license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright
- * ownership. Elasticsearch B.V. licenses this file to you under
- * the Apache License, Version 2.0 (the "License"); you may
- * not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *    http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-const context = require.context('../directives', false, /[\/\\](?!\.|_)[^\/\\]+\.js/);
-context.keys().forEach(key => context(key));

src/legacy/ui/public/autoload/modules.js

@@ -19,23 +19,10 @@
 
 import 'angular';
 import '../chrome';
-import '../bind';
-import '../kbn_top_nav';
-import '../bound_to_config_obj';
 import '../config';
 import '../courier';
-import '../debounce';
-import '../doc_title';
 import '../es';
-import '../events';
-import '../fancy_forms';
-import '../filter_bar';
-import '../filter_manager';
-import '../index_patterns';
-import '../listen';
 import '../notify';
-import '../parse_query';
-import '../persisted_log';
 import '../private';
 import '../promises';
 import '../modals';
@@ -43,15 +30,11 @@ import '../state_management/app_state';
 import '../state_management/global_state';
 import '../storage';
 import '../style_compile';
-import '../timefilter';
-import '../timepicker';
 import '../tooltip';
 import '../url';
 import '../watch_multi';
-import '../saved_objects/ui/saved_object_save_as_checkbox';
 import '../react_components';
 import '../i18n';
-import '../query_bar/directive';
 
 import '@elastic/ui-ace';
 import { uiModules } from 'ui/modules';

src/legacy/ui/public/courier/courier.js

@@ -22,6 +22,7 @@ import _ from 'lodash';
 import { timefilter } from 'ui/timefilter';
 
 import '../es';
+import '../listen';
 import '../index_patterns';
 import { uiModules } from '../modules';
 import { addFatalErrorCallback } from '../notify';

src/legacy/ui/public/directives/paginated_selectable_list.js

@@ -19,6 +19,8 @@
 
 import _ from 'lodash';
 import { uiModules } from '../modules';
+import './paginate';
+import './kbn_href';
 import paginatedSelectableListTemplate from '../partials/paginated_selectable_list.html';
 
 const module = uiModules.get('kibana');

src/legacy/ui/public/directives/saved_object_finder.js

@@ -23,6 +23,8 @@ import { keyMap } from '../utils/key_map';
 import { SavedObjectRegistryProvider } from '../saved_objects/saved_object_registry';
 import { uiModules } from '../modules';
 import savedObjectFinderTemplate from '../partials/saved_object_finder.html';
+import './input_focus';
+import './paginate';
 
 const module = uiModules.get('kibana');
 

src/legacy/ui/public/doc_table/doc_table.js

@@ -20,7 +20,7 @@
 import _ from 'lodash';
 import html from './doc_table.html';
 import { getSort } from './lib/get_sort';
-import '../directives/infinite_scroll';
+import './infinite_scroll';
 import './components/table_header';
 import './components/table_row';
 import { dispatchRenderComplete } from '../render_complete';

src/legacy/ui/public/doc_table/infinite_scroll.js

@@ -19,7 +19,7 @@
 
 import $ from 'jquery';
 import { uiModules } from '../modules';
-const module = uiModules.get('kibana');
+const module = uiModules.get('app/discover');
 
 module.directive('kbnInfiniteScroll', function () {
   return {

src/legacy/ui/public/kbn_top_nav/kbn_top_nav.js

@@ -55,6 +55,7 @@
 
 import _ from 'lodash';
 import angular from 'angular';
+import '../timepicker';
 import '../watch_multi';
 import '../directives/input_focus';
 import { uiModules } from '../modules';

src/legacy/ui/public/number_list/number_list.js

@@ -20,6 +20,7 @@
 import _ from 'lodash';
 import { parseRange } from '../utils/range';
 import './number_list_input';
+import '../directives/input_focus';
 import { uiModules } from '../modules';
 import numberListTemplate from './number_list.html';
 

src/legacy/ui/public/number_list/number_list_input.js

@@ -18,6 +18,7 @@
  */
 
 import { keyMap } from '../utils/key_map';
+import '../fancy_forms';
 import { uiModules } from '../modules';
 
 const INVALID = {}; // invalid flag

src/legacy/ui/public/paginated_table/paginated_table.js

@@ -20,6 +20,9 @@
 import _ from 'lodash';
 import { uiModules } from '../modules';
 import paginatedTableTemplate from './paginated_table.html';
+
+import '../directives/paginate';
+
 uiModules
   .get('kibana')
   .directive('paginatedTable', function ($filter) {

src/legacy/ui/public/vis/editors/default/agg.js

@@ -21,6 +21,7 @@ import './agg_params';
 import './agg_add';
 import { Direction } from './keyboard_move';
 import _ from 'lodash';
+import '../../../fancy_forms';
 import { uiModules } from '../../../modules';
 import aggTemplate from './agg.html';
 import { move } from '../../../utils/collection';

src/legacy/ui/public/vis/editors/default/sidebar.js

@@ -20,6 +20,7 @@
 import _ from 'lodash';
 import './agg_group';
 import './vis_options';
+import 'ui/directives/css_truncate';
 import { uiModules } from '../../../modules';
 import sidebarTemplate from './sidebar.html';
 

src/legacy/ui/public/vis/vis.js

@@ -36,7 +36,9 @@ import { FilterBarQueryFilterProvider } from '../filter_bar/query_filter';
 import { updateVisualizationConfig } from './vis_update';
 import { SearchSourceProvider } from '../courier/search_source';
 import { SavedObjectsClientProvider } from '../saved_objects';
-import { timefilter } from 'ui/timefilter';
+
+import { timefilter } from '../timefilter';
+import '../bind';
 
 export function VisProvider(Private, indexPatterns, getAppState) {
   const visTypes = Private(VisTypesRegistryProvider);

x-pack/plugins/graph/public/app.js

@@ -14,7 +14,11 @@ import 'uiExports/fieldFormats';
 import 'uiExports/savedObjectTypes';
 
 import 'ui/autoload/all';
+// TODO: remove ui imports completely (move to plugins)
+import 'ui/kbn_top_nav';
 import 'ui/directives/saved_object_finder';
+import 'ui/directives/input_focus';
+import 'ui/saved_objects/ui/saved_object_save_as_checkbox';
 import chrome from 'ui/chrome';
 import { uiModules } from 'ui/modules';
 import uiRoutes from 'ui/routes';

x-pack/plugins/maps/public/angular/map_controller.js

@@ -5,6 +5,7 @@
  */
 
 import chrome from 'ui/chrome';
+import 'ui/listen';
 import React from 'react';
 import { I18nProvider } from '@kbn/i18n/react';
 import { i18n } from '@kbn/i18n';

x-pack/plugins/maps/public/index.js

@@ -19,6 +19,8 @@ import 'ui/agg_types';
 
 import chrome from 'ui/chrome';
 import routes from 'ui/routes';
+import 'ui/kbn_top_nav';
+import 'ui/query_bar/directive';
 import { uiModules } from 'ui/modules';
 import { DocTitleProvider } from 'ui/doc_title';
 import 'ui/autoload/styles';

x-pack/plugins/ml/public/app.js

@@ -13,6 +13,7 @@ import 'ui/courier';
 import 'ui/angular-bootstrap';
 import 'ui/persisted_log';
 import 'ui/autoload/all';
+import 'ui/kbn_top_nav';
 
 import 'plugins/ml/access_denied';
 import 'plugins/ml/lib/angular_bootstrap_patch';

x-pack/plugins/ml/public/components/nav_menu/nav_menu.js

@@ -11,6 +11,8 @@ import { isFullLicense } from '../../license/check_license';
 import { uiModules } from 'ui/modules';
 const module = uiModules.get('apps/ml');
 
+import 'ui/directives/kbn_href';
+
 module.directive('mlNavMenu', function () {
   return {
     restrict: 'E',

x-pack/plugins/ml/public/jobs/new_job/advanced/new_job_controller.js

@@ -10,6 +10,7 @@ import _ from 'lodash';
 import angular from 'angular';
 import 'ace';
 import 'ui/angular_ui_select';
+import 'ui/directives/input_focus';
 
 import { parseInterval } from 'ui/utils/parse_interval';
 import { timefilter } from 'ui/timefilter';

x-pack/plugins/ml/public/jobs/new_job/wizard/steps/index_or_search/index_or_search_controller.js

@@ -20,6 +20,8 @@ import { loadIndexPatterns, getIndexPatterns } from 'plugins/ml/util/index_utils
 import { checkMlNodesAvailable } from 'plugins/ml/ml_nodes_check/check_ml_nodes';
 import template from './index_or_search.html';
 import { timefilter } from 'ui/timefilter';
+import 'ui/directives/paginated_selectable_list';
+import 'ui/directives/saved_object_finder';
 
 uiRoutes
   .when('/jobs/new_job', {

x-pack/plugins/monitoring/public/directives/main/index.js

@@ -8,6 +8,7 @@ import { get } from 'lodash';
 import { uiModules } from 'ui/modules';
 import template from './index.html';
 import { shortenPipelineHash } from '../../../common/formatting';
+import 'ui/directives/kbn_href';
 
 /*
  * Manage data and provide helper methods for the "main" directive's template

x-pack/plugins/monitoring/public/monitoring.js

@@ -6,6 +6,7 @@
 
 import uiRoutes from 'ui/routes';
 import chrome from 'ui/chrome';
+import 'ui/kbn_top_nav';
 import 'ui/autoload/all';
 import 'plugins/monitoring/filters';
 import 'plugins/monitoring/services/clusters';

x-pack/plugins/monitoring/public/views/no_data/controller.js

@@ -16,6 +16,7 @@ import { render, unmountComponentAtNode } from 'react-dom';
 import { NoData } from 'plugins/monitoring/components';
 import { timefilter } from 'ui/timefilter';
 import { I18nContext } from 'ui/i18n';
+import 'ui/listen';
 
 const REACT_NODE_ID_NO_DATA = 'noDataReact';
 

x-pack/plugins/watcher/public/components/duration_select/duration_select.js

@@ -4,6 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
+import 'ui/fancy_forms';
 import { uiModules } from 'ui/modules';
 import { InitAfterBindingsWorkaround } from 'ui/compat';
 import { TIME_UNITS } from 'plugins/watcher/constants';

x-pack/plugins/watcher/public/components/expression_builder/components/expression_item/expression_item.js

@@ -4,6 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
+import 'ui/fancy_forms';
 import { uiModules } from 'ui/modules';
 import { keyMap } from 'ui/utils/key_map';
 import template from './expression_item.html';

x-pack/plugins/watcher/public/components/json_editor/json_editor.js

@@ -6,6 +6,7 @@
 
 import { uiModules } from 'ui/modules';
 import template from './json_editor.html';
+import 'ui/directives/json_input';
 import 'ace';
 
 const app = uiModules.get('xpack/watcher');

x-pack/plugins/watcher/public/components/watch_actions/components/watch_action/watch_action.js

@@ -4,6 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
+import 'ui/fancy_forms';
 import { uiModules } from 'ui/modules';
 import template from './watch_action.html';
 import angular from 'angular';

x-pack/plugins/watcher/public/components/watch_history_item_detail/watch_history_item_detail.js

@@ -5,6 +5,7 @@
  */
 
 import { uiModules } from 'ui/modules';
+import 'ui/directives/json_input';
 import template from './watch_history_item_detail.html';
 import 'ace';