maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Transform] Fix aggregation name override for the top_metrics aggs (#104446)

Browse source 
* [Transform] Fix aggName for the top_metrics agg

* [Transform] update comment
This commit is contained in:
Dima Arnautov 2021-07-06 17:39:13 +02:00 committed by GitHub
parent 763ba305d4
commit 901ad6391a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
x-pack/plugins/transform/public/app/sections/create_transform/components/step_define/common/get_default_aggregation_config.ts
View file

@ -43,7 +43,11 @@ export function getDefaultAggregationConfig(
case PIVOT_SUPPORTED_AGGS.FILTER:
return getFilterAggConfig(commonConfig);
case PIVOT_SUPPORTED_AGGS.TOP_METRICS:
return getTopMetricsAggConfig(commonConfig);
return getTopMetricsAggConfig({
...commonConfig,
// top_metrics agg has different naming convention by default
aggName: PIVOT_SUPPORTED_AGGS.TOP_METRICS,
});
default:
return commonConfig;
}

3
x-pack/plugins/transform/public/app/sections/create_transform/components/step_define/common/top_metrics_agg/config.ts
View file

@ -17,7 +17,6 @@ import {
import { PivotAggsConfigTopMetrics } from './types';
import { TopMetricsAggForm } from './components/top_metrics_agg_form';
import { isPopulatedObject } from '../../../../../../../../common/shared_imports';
import { PIVOT_SUPPORTED_AGGS } from '../../../../../../../../common/types/pivot_aggs';
/**
* Gets initial basic configuration of the top_metrics aggregation.
@ -31,8 +30,6 @@ export function getTopMetricsAggConfig(
isMultiField: true,
field: isPivotAggsConfigWithUiSupport(commonConfig) ? commonConfig.field : '',
AggFormComponent: TopMetricsAggForm,
/** Default name */
aggName: PIVOT_SUPPORTED_AGGS.TOP_METRICS,
aggConfig: {},
getEsAggConfig() {
// ensure the configuration has been completed