maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[ML] Functional tests - stabilize slider value selection (#94313)

Browse source 
This PR stabilizes the slider value selection during ML functional tests.
This commit is contained in:
Robert Oskamp 2021-03-11 10:11:53 +01:00 committed by GitHub
parent ad0517a905
commit 92307bfe29
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
x-pack/test/functional/services/ml/common_ui.ts
View file

@ -167,10 +167,10 @@ export function MachineLearningCommonUIProvider({ getService }: FtrProviderConte
async setSliderValue(testDataSubj: string, value: number) {
const slider = await testSubjects.find(testDataSubj);
let currentValue = await slider.getAttribute('value');
let currentDiff = +currentValue - +value;
await retry.tryForTime(60 * 1000, async () => {
const currentValue = await slider.getAttribute('value');
const currentDiff = +currentValue - +value;
if (currentDiff === 0) {
return true;
} else {
@ -189,20 +189,13 @@ export function MachineLearningCommonUIProvider({ getService }: FtrProviderConte
}
await retry.tryForTime(1000, async () => {
const newValue = await slider.getAttribute('value');
if (newValue !== currentValue) {
currentValue = newValue;
currentDiff = +currentValue - +value;
return true;
} else {
if (newValue === currentValue) {
throw new Error(`slider value should have changed, but is still ${currentValue}`);
}
});
throw new Error(`slider value should be '${value}' (got '${currentValue}')`);
await this.assertSliderValue(testDataSubj, value);
}
});
await this.assertSliderValue(testDataSubj, value);
},
async assertSliderValue(testDataSubj: string, expectedValue: number) {