maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[APM] Handle correlations view with missing field names (#93443) (#94015)

Browse source 
* [APM] Handle correlations view with missing field names (#93443)

* fixes spelling

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Oliver Gupte 2021-03-09 12:37:11 -08:00 committed by GitHub
parent 4eff7a0709
commit 931b54f636
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
x-pack/plugins/apm/public/components/app/correlations/error_correlations.tsx
View file

@ -63,10 +63,11 @@ export function ErrorCorrelations({ onClose }: Props) {
`apm.correlations.errors.fields:${serviceName}`,
defaultFieldNames
);
const hasFieldNames = fieldNames.length > 0;
const { data, status } = useFetcher(
(callApmApi) => {
if (start && end) {
if (start && end && hasFieldNames) {
return callApmApi({
endpoint: 'GET /api/apm/correlations/failed_transactions',
params: {
@ -93,6 +94,7 @@ export function ErrorCorrelations({ onClose }: Props) {
transactionName,
transactionType,
fieldNames,
hasFieldNames,
]
);
@ -123,7 +125,7 @@ export function ErrorCorrelations({ onClose }: Props) {
</EuiFlexItem>
<EuiFlexItem>
<ErrorTimeseriesChart
data={data}
data={hasFieldNames ? data : undefined}
status={status}
selectedSignificantTerm={selectedSignificantTerm}
/>
@ -134,7 +136,7 @@ export function ErrorCorrelations({ onClose }: Props) {
'xpack.apm.correlations.error.percentageColumnName',
{ defaultMessage: '% of failed transactions' }
)}
significantTerms={data?.significantTerms}
significantTerms={hasFieldNames ? data?.significantTerms : []}
status={status}
setSelectedSignificantTerm={setSelectedSignificantTerm}
onFilter={onClose}

9
x-pack/plugins/apm/public/components/app/correlations/latency_correlations.tsx
View file

@ -61,6 +61,8 @@ export function LatencyCorrelations({ onClose }: Props) {
`apm.correlations.latency.fields:${serviceName}`,
defaultFieldNames
);
const hasFieldNames = fieldNames.length > 0;
const [
durationPercentile,
setDurationPercentile,
@ -71,7 +73,7 @@ export function LatencyCorrelations({ onClose }: Props) {
const { data, status } = useFetcher(
(callApmApi) => {
if (start && end) {
if (start && end && hasFieldNames) {
return callApmApi({
endpoint: 'GET /api/apm/correlations/slow_transactions',
params: {
@ -100,6 +102,7 @@ export function LatencyCorrelations({ onClose }: Props) {
transactionType,
durationPercentile,
fieldNames,
hasFieldNames,
]
);
@ -131,7 +134,7 @@ export function LatencyCorrelations({ onClose }: Props) {
</h4>
</EuiTitle>
<LatencyDistributionChart
data={data}
data={hasFieldNames ? data : undefined}
status={status}
selectedSignificantTerm={selectedSignificantTerm}
/>
@ -144,7 +147,7 @@ export function LatencyCorrelations({ onClose }: Props) {
'xpack.apm.correlations.latency.percentageColumnName',
{ defaultMessage: '% of slow transactions' }
)}
significantTerms={data?.significantTerms}
significantTerms={hasFieldNames ? data?.significantTerms : []}
status={status}
setSelectedSignificantTerm={setSelectedSignificantTerm}
onFilter={onClose}