maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Discover] Fix persistence of "hide/show chart" in saved search (#92731) (#92894)

Browse source
This commit is contained in:
Wylie Conlon 2021-02-25 16:28:14 -05:00 committed by GitHub
parent 68c4db087a
commit 953b9ad5fe
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/plugins/discover/public/application/helpers/persist_saved_search.ts
View file

@ -49,7 +49,7 @@ export async function persistSavedSearch(
if (state.grid) {
savedSearch.grid = state.grid;
}
if (state.hideChart) {
if (typeof state.hideChart !== 'undefined') {
savedSearch.hideChart = state.hideChart;
}

14
test/functional/apps/discover/_discover_histogram.ts
View file

@ -97,15 +97,25 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(canvasExists).to.be(false);
await PageObjects.discover.saveSearch(savedSearch);
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.clickNewSearchButton();
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.loadSavedSearch('persisted hidden histogram');
await PageObjects.header.waitUntilLoadingHasFinished();
canvasExists = await elasticChart.canvasExists();
expect(canvasExists).to.be(false);
await testSubjects.click('discoverChartToggle');
canvasExists = await elasticChart.canvasExists();
expect(canvasExists).to.be(true);
await PageObjects.discover.clickResetSavedSearchButton();
await PageObjects.discover.saveSearch('persisted hidden histogram');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.clickNewSearchButton();
await PageObjects.discover.loadSavedSearch('persisted hidden histogram');
await PageObjects.header.waitUntilLoadingHasFinished();
canvasExists = await elasticChart.canvasExists();
expect(canvasExists).to.be(false);
expect(canvasExists).to.be(true);
});
});
}