From 98adaee778748f349dd4b87e751d8223082d5361 Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Tue, 17 Dec 2019 12:49:05 +0000 Subject: [PATCH] Increases log rotation file size minimum limit (#53169) (#53248) * fix(NA): increase log rotation minimum log filesize to rotate limit * chore(NA): correct interval * docs(NA): add comments to explain everyBytes limits --- docs/setup/settings.asciidoc | 2 +- src/legacy/server/config/schema.js | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/docs/setup/settings.asciidoc b/docs/setup/settings.asciidoc index 86f5ea34c290..e5707a06d36d 100644 --- a/docs/setup/settings.asciidoc +++ b/docs/setup/settings.asciidoc @@ -171,7 +171,7 @@ that feature would not take any effect. `logging.rotate.everyBytes:`:: [experimental] *Default: 10485760* The maximum size of a log file (that is `not an exact` limit). After the limit is reached, a new log file is generated. The default size limit is 10485760 (10 MB) and -this option should be at least greater than 1024. +this option should be in the range of 102400 (100KB) to 1073741824 (1GB). `logging.rotate.keepFiles:`:: [experimental] *Default: 7* The number of most recent rotated log files to keep on disk. Older files are deleted during log rotation. The default value is 7. The `logging.rotate.keepFiles` diff --git a/src/legacy/server/config/schema.js b/src/legacy/server/config/schema.js index b31939adee6b..193011c0b8be 100644 --- a/src/legacy/server/config/schema.js +++ b/src/legacy/server/config/schema.js @@ -144,7 +144,11 @@ export default () => .keys({ enabled: Joi.boolean().default(false), everyBytes: Joi.number() - .greater(1024) + // > 100KB + .greater(102399) + // < 1GB + .less(1073741825) + // 10MB .default(10485760), keepFiles: Joi.number() .greater(2)