maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Register navLink actions for declared applications (#72109)

Browse source
This commit is contained in:
Larry Gregory 2020-07-17 05:38:55 -04:00 committed by GitHub
parent 6164037f18
commit 99e14aad76
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
x-pack/plugins/security/server/authorization/privileges/feature_privilege_builder/navlink.ts
View file

@ -9,6 +9,9 @@ import { BaseFeaturePrivilegeBuilder } from './feature_privilege_builder';
export class FeaturePrivilegeNavlinkBuilder extends BaseFeaturePrivilegeBuilder {
public getActions(privilegeDefinition: FeatureKibanaPrivileges, feature: Feature): string[] {
return feature.navLinkId ? [this.actions.ui.get('navLinks', feature.navLinkId)] : [];
const appNavLinks = feature.app.map((app) => this.actions.ui.get('navLinks', app));
return feature.navLinkId
? [this.actions.ui.get('navLinks', feature.navLinkId), ...appNavLinks]
: appNavLinks;
}
}

18
x-pack/plugins/security/server/authorization/privileges/privileges.test.ts
View file

@ -54,8 +54,20 @@ describe('features', () => {
const actual = privileges.get();
expect(actual).toHaveProperty('features.foo-feature', {
all: [actions.login, actions.version, actions.ui.get('navLinks', 'kibana:foo')],
read: [actions.login, actions.version, actions.ui.get('navLinks', 'kibana:foo')],
all: [
actions.login,
actions.version,
actions.ui.get('navLinks', 'kibana:foo'),
actions.ui.get('navLinks', 'app-1'),
actions.ui.get('navLinks', 'app-2'),
],
read: [
actions.login,
actions.version,
actions.ui.get('navLinks', 'kibana:foo'),
actions.ui.get('navLinks', 'app-1'),
actions.ui.get('navLinks', 'app-2'),
],
});
});
@ -635,6 +647,8 @@ describe('reserved', () => {
expect(actual).toHaveProperty('reserved.foo', [
actions.version,
actions.ui.get('navLinks', 'kibana:foo'),
actions.ui.get('navLinks', 'app-1'),
actions.ui.get('navLinks', 'app-2'),
]);
});