From 9c3c489e481c5fe9992584a3a1db2e37ce8f3bf5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?David=20S=C3=A1nchez?= <davidsansol92@gmail.com>
Date: Tue, 26 Oct 2021 09:21:58 +0200
Subject: [PATCH] Hide or button if needed (#116124)

---
 .../builder/exception_items_renderer.tsx      |  3 ++
 .../components/builder/logic_buttons.test.tsx | 19 +++++++++++++
 .../components/builder/logic_buttons.tsx      | 28 +++++++++++--------
 .../view/components/form/index.tsx            |  3 +-
 4 files changed, 40 insertions(+), 13 deletions(-)

diff --git a/x-pack/plugins/lists/public/exceptions/components/builder/exception_items_renderer.tsx b/x-pack/plugins/lists/public/exceptions/components/builder/exception_items_renderer.tsx
index 1b25a2cb91e8..280dd8acbc7e 100644
--- a/x-pack/plugins/lists/public/exceptions/components/builder/exception_items_renderer.tsx
+++ b/x-pack/plugins/lists/public/exceptions/components/builder/exception_items_renderer.tsx
@@ -81,6 +81,7 @@ export interface ExceptionBuilderProps {
   isAndDisabled: boolean;
   isNestedDisabled: boolean;
   isOrDisabled: boolean;
+  isOrHidden?: boolean;
   listId: string;
   listNamespaceType: NamespaceType;
   listType: ExceptionListType;
@@ -103,6 +104,7 @@ export const ExceptionBuilderComponent = ({
   isAndDisabled,
   isNestedDisabled,
   isOrDisabled,
+  isOrHidden = false,
   listId,
   listNamespaceType,
   listType,
@@ -433,6 +435,7 @@ export const ExceptionBuilderComponent = ({
           <EuiFlexItem grow={1}>
             <BuilderLogicButtons
               isOrDisabled={isOrDisabled ? isOrDisabled : disableOr}
+              isOrHidden={isOrHidden}
               isAndDisabled={isAndDisabled ? isAndDisabled : disableAnd}
               isNestedDisabled={isNestedDisabled ? isNestedDisabled : disableNested}
               isNested={addNested}
diff --git a/x-pack/plugins/lists/public/exceptions/components/builder/logic_buttons.test.tsx b/x-pack/plugins/lists/public/exceptions/components/builder/logic_buttons.test.tsx
index 7eb6fec9c50f..584bab005759 100644
--- a/x-pack/plugins/lists/public/exceptions/components/builder/logic_buttons.test.tsx
+++ b/x-pack/plugins/lists/public/exceptions/components/builder/logic_buttons.test.tsx
@@ -34,6 +34,25 @@ describe('BuilderLogicButtons', () => {
     expect(wrapper.find('[data-test-subj="exceptionsNestedButton"] button')).toHaveLength(0);
   });
 
+  test('it hides "or" button', () => {
+    const wrapper = mount(
+      <BuilderLogicButtons
+        isAndDisabled={false}
+        isOrDisabled={false}
+        isOrHidden={true}
+        isNestedDisabled={false}
+        isNested={false}
+        showNestedButton={false}
+        onOrClicked={jest.fn()}
+        onAndClicked={jest.fn()}
+        onNestedClicked={jest.fn()}
+        onAddClickWhenNested={jest.fn()}
+      />
+    );
+
+    expect(wrapper.find('[data-test-subj="exceptionsOrButton"] button')).toHaveLength(0);
+  });
+
   test('it invokes "onOrClicked" when "or" button is clicked', () => {
     const onOrClicked = jest.fn();
 
diff --git a/x-pack/plugins/lists/public/exceptions/components/builder/logic_buttons.tsx b/x-pack/plugins/lists/public/exceptions/components/builder/logic_buttons.tsx
index 3846b844bb55..aa308ecdc345 100644
--- a/x-pack/plugins/lists/public/exceptions/components/builder/logic_buttons.tsx
+++ b/x-pack/plugins/lists/public/exceptions/components/builder/logic_buttons.tsx
@@ -20,6 +20,7 @@ interface BuilderLogicButtonsProps {
   isNested: boolean;
   isNestedDisabled: boolean;
   isOrDisabled: boolean;
+  isOrHidden?: boolean;
   showNestedButton: boolean;
   onAddClickWhenNested: () => void;
   onAndClicked: () => void;
@@ -32,6 +33,7 @@ export const BuilderLogicButtons: React.FC<BuilderLogicButtonsProps> = ({
   isNested,
   isNestedDisabled = true,
   isOrDisabled = false,
+  isOrHidden = false,
   showNestedButton = false,
   onAddClickWhenNested,
   onAndClicked,
@@ -50,18 +52,20 @@ export const BuilderLogicButtons: React.FC<BuilderLogicButtonsProps> = ({
         {i18n.AND}
       </MyEuiButton>
     </EuiFlexItem>
-    <EuiFlexItem grow={false}>
-      <MyEuiButton
-        fill
-        size="s"
-        iconType="plusInCircle"
-        onClick={onOrClicked}
-        isDisabled={isOrDisabled}
-        data-test-subj="exceptionsOrButton"
-      >
-        {i18n.OR}
-      </MyEuiButton>
-    </EuiFlexItem>
+    {!isOrHidden && (
+      <EuiFlexItem grow={false}>
+        <MyEuiButton
+          fill
+          size="s"
+          iconType="plusInCircle"
+          onClick={onOrClicked}
+          isDisabled={isOrDisabled}
+          data-test-subj="exceptionsOrButton"
+        >
+          {i18n.OR}
+        </MyEuiButton>
+      </EuiFlexItem>
+    )}
     {showNestedButton && (
       <EuiFlexItem grow={false}>
         <EuiButton
diff --git a/x-pack/plugins/security_solution/public/management/pages/event_filters/view/components/form/index.tsx b/x-pack/plugins/security_solution/public/management/pages/event_filters/view/components/form/index.tsx
index a024012b4135..ced0abcea025 100644
--- a/x-pack/plugins/security_solution/public/management/pages/event_filters/view/components/form/index.tsx
+++ b/x-pack/plugins/security_solution/public/management/pages/event_filters/view/components/form/index.tsx
@@ -129,7 +129,8 @@ export const EventFiltersForm: React.FC<EventFiltersFormProps> = memo(
           listNamespaceType: 'agnostic',
           ruleName: RULE_NAME,
           indexPatterns,
-          isOrDisabled: true, // TODO: pending to be validated
+          isOrDisabled: true,
+          isOrHidden: true,
           isAndDisabled: false,
           isNestedDisabled: false,
           dataTestSubj: 'alert-exception-builder',