maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Flaky test fix for Actions and Triggers app alerts should delete all selection (#86175)

Browse source 
* Removed skip test for delete all alerts integration test

* fixed typechecks

* reduced nuber of selected alert to delete to a single one

* fixed due to comments

* removed long timing retry

* fixed typechecks

* fixed failing tests
This commit is contained in:
Yuliia Naumenko 2021-01-05 10:10:52 -08:00 committed by GitHub
parent b9a72fe4cb
commit 9d12b1c71b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alerts_list.ts
View file

@ -4,7 +4,6 @@
* you may not use this file except in compliance with the Elastic License.
*/
import { times } from 'lodash';
import expect from '@kbn/expect';
import { FtrProviderContext } from '../../ftr_provider_context';
import { ObjectRemover } from '../../lib/object_remover';
@ -322,18 +321,13 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
expect(isChecked).to.eql('false');
});
it.skip('should delete all selection', async () => {
it('should delete all selection', async () => {
const namePrefix = generateUniqueKey();
let count = 0;
const createdAlertsFirstPage = await Promise.all(
times(2, () => createAlertManualCleanup({ name: `${namePrefix}-0${count++}` }))
);
const createdAlert = await createAlertManualCleanup({ name: `${namePrefix}-1` });
await refreshAlertsList();
await pageObjects.triggersActionsUI.searchAlerts(namePrefix);
for (const createdAlert of createdAlertsFirstPage) {
await testSubjects.click(`checkboxSelectRow-${createdAlert.id}`);
}
await testSubjects.click(`checkboxSelectRow-${createdAlert.id}`);
await testSubjects.click('bulkAction');
@ -342,9 +336,9 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await testSubjects.click('deleteIdsConfirmation > confirmModalConfirmButton');
await testSubjects.missingOrFail('deleteIdsConfirmation');
await retry.tryForTime(30000, async () => {
await retry.try(async () => {
const toastTitle = await pageObjects.common.closeToast();
expect(toastTitle).to.eql('Deleted 2 alerts');
expect(toastTitle).to.eql('Deleted 1 alert');
});
await pageObjects.triggersActionsUI.searchAlerts(namePrefix);