maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Maps] Fix apis Maps endpoints getTile should return vector tile containing document (#114509)

Browse source 
* [Maps] Fix apis Maps endpoints getTile should return vector tile containing document

* use find instead of if statement

* eslint

* can not use layer.feature.find is layer.feature is not an array

* unskip other test where fix has been merged

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Nathan Reese 2021-10-12 06:29:36 -06:00 committed by GitHub
parent adb49b7d37
commit 9e65b12c4b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
x-pack/test/api_integration/apis/maps/get_tile.js
View file

@ -10,11 +10,19 @@ import Protobuf from 'pbf';
import expect from '@kbn/expect';
import { MVT_SOURCE_LAYER_NAME } from '../../../../plugins/maps/common/constants';
function findFeature(layer, callbackFn) {
for (let i = 0; i < layer.length; i++) {
const feature = layer.feature(i);
if (callbackFn(feature)) {
return feature;
}
}
}
export default function ({ getService }) {
const supertest = getService('supertest');
// FAILING ES PROMOTION: https://github.com/elastic/kibana/issues/114471
describe.skip('getTile', () => {
describe('getTile', () => {
it('should return vector tile containing document', async () => {
const resp = await supertest
.get(
@ -32,8 +40,12 @@ export default function ({ getService }) {
const layer = jsonTile.layers[MVT_SOURCE_LAYER_NAME];
expect(layer.length).to.be(3); // 2 docs + the metadata feature
// 1st doc
const feature = layer.feature(0);
// Verify ES document
const feature = findFeature(layer, (feature) => {
return feature.properties._id === 'AU_x3_BsGFA8no6Qjjug';
});
expect(feature).not.to.be(undefined);
expect(feature.type).to.be(1);
expect(feature.extent).to.be(4096);
expect(feature.id).to.be(undefined);
@ -46,8 +58,11 @@ export default function ({ getService }) {
});
expect(feature.loadGeometry()).to.eql([[{ x: 44, y: 2382 }]]);
// Metadata feature
const metadataFeature = layer.feature(2);
// Verify metadata feature
const metadataFeature = findFeature(layer, (feature) => {
return feature.properties.__kbn_metadata_feature__;
});
expect(metadataFeature).not.to.be(undefined);
expect(metadataFeature.type).to.be(3);
expect(metadataFeature.extent).to.be(4096);
expect(metadataFeature.id).to.be(undefined);

3
x-pack/test/functional/apps/maps/documents_source/docvalue_fields.js
View file

@ -11,8 +11,7 @@ export default function ({ getPageObjects, getService }) {
const PageObjects = getPageObjects(['maps']);
const security = getService('security');
// FLAKY: https://github.com/elastic/kibana/issues/114418
describe.skip('docvalue_fields', () => {
describe('docvalue_fields', () => {
before(async () => {
await security.testUser.setRoles(['global_maps_read', 'test_logstash_reader'], false);
});