From 9eed9ee39bdb277a5e9005aabc2401ea2ba1629b Mon Sep 17 00:00:00 2001 From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Date: Mon, 11 Oct 2021 11:24:42 -0400 Subject: [PATCH] correct relativity in images (#113834) (#114484) Co-authored-by: Kellen <9484709+goodroot@users.noreply.github.com> --- dev_docs/contributing/best_practices.mdx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dev_docs/contributing/best_practices.mdx b/dev_docs/contributing/best_practices.mdx index d740ee307dac..1e1847cfd17d 100644 --- a/dev_docs/contributing/best_practices.mdx +++ b/dev_docs/contributing/best_practices.mdx @@ -111,7 +111,7 @@ export getSearchService: (searchSpec: { username: string; password: string }) => In the former, there will be a link to the `SearchSpec` interface with documentation for the `username` and `password` properties. In the latter the object will render inline, without comments: -![prefer interfaces documentation](./assets/dev_docs_nested_object.png) +![prefer interfaces documentation](../assets/dev_docs_nested_object.png) #### Export every type used in a public API @@ -135,7 +135,7 @@ export type foo: string | AnInterface; `Pick` not only ends up being unhelpful in our documentation system, but it's also of limited help in your IDE. For that reason, avoid `Pick` and other similarly complex types on your public API items. Using these semantics internally is fine. -![pick api documentation](./assets/api_doc_pick.png) +![pick api documentation](../assets/api_doc_pick.png) ### Example plugins @@ -210,7 +210,7 @@ your large change right _after_ feature freeze. If you are worried about missing When possible, build features with incrementals sets of smallĀ and focused PRs, but don't check in unused code, and don't expose any feature on master that you would not be comfortable releasing. -![product_stages](./assets/product_stages.png) +![product_stages](../assets/product_stages.png) If your feature cannot be broken down into smaller components, or multiple engineers will be contributing, you have a few other options to consider.