maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[App Search] Static Curations History Tab (#113481)

Browse source
This commit is contained in:
Davey Holler 2021-10-13 12:21:46 -07:00 committed by GitHub
parent 8d1c96cd7e
commit a532ea5c05
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
13 changed files with 278 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/curations_logic.ts
View file

@ -23,7 +23,7 @@ import { EngineLogic, generateEnginePath } from '../engine';
import { DELETE_CONFIRMATION_MESSAGE, DELETE_SUCCESS_MESSAGE } from './constants';
import { Curation, CurationsAPIResponse } from './types';
type CurationsPageTabs = 'overview' | 'settings';
type CurationsPageTabs = 'overview' | 'settings' | 'history';
interface CurationsValues {
dataLoading: boolean;

18
x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/views/curations.test.tsx
View file

@ -19,6 +19,7 @@ import { EuiTab } from '@elastic/eui';
import { getPageHeaderTabs, getPageTitle } from '../../../../test_helpers';
import { Curations } from './curations';
import { CurationsHistory } from './curations_history/curations_history';
import { CurationsOverview } from './curations_overview';
import { CurationsSettings } from './curations_settings';
@ -70,7 +71,10 @@ describe('Curations', () => {
expect(actions.onSelectPageTab).toHaveBeenNthCalledWith(1, 'overview');
tabs.at(1).simulate('click');
expect(actions.onSelectPageTab).toHaveBeenNthCalledWith(2, 'settings');
expect(actions.onSelectPageTab).toHaveBeenNthCalledWith(2, 'history');
tabs.at(2).simulate('click');
expect(actions.onSelectPageTab).toHaveBeenNthCalledWith(3, 'settings');
});
it('renders an overview view', () => {
@ -83,12 +87,22 @@ describe('Curations', () => {
expect(wrapper.find(CurationsOverview)).toHaveLength(1);
});
it('renders a history view', () => {
setMockValues({ ...values, selectedPageTab: 'history' });
const wrapper = shallow(<Curations />);
const tabs = getPageHeaderTabs(wrapper).find(EuiTab);
expect(tabs.at(1).prop('isSelected')).toEqual(true);
expect(wrapper.find(CurationsHistory)).toHaveLength(1);
});
it('renders a settings view', () => {
setMockValues({ ...values, selectedPageTab: 'settings' });
const wrapper = shallow(<Curations />);
const tabs = getPageHeaderTabs(wrapper).find(EuiTab);
expect(tabs.at(1).prop('isSelected')).toEqual(true);
expect(tabs.at(2).prop('isSelected')).toEqual(true);
expect(wrapper.find(CurationsSettings)).toHaveLength(1);
});

12
x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/views/curations.tsx
View file

@ -21,6 +21,7 @@ import { CURATIONS_OVERVIEW_TITLE, CREATE_NEW_CURATION_TITLE } from '../constant
import { CurationsLogic } from '../curations_logic';
import { getCurationsBreadcrumbs } from '../utils';
import { CurationsHistory } from './curations_history/curations_history';
import { CurationsOverview } from './curations_overview';
import { CurationsSettings } from './curations_settings';
@ -39,6 +40,16 @@ export const Curations: React.FC = () => {
isSelected: selectedPageTab === 'overview',
onClick: () => onSelectPageTab('overview'),
},
{
label: i18n.translate(
'xpack.enterpriseSearch.appSearch.engine.curations.historyPageTabLabel',
{
defaultMessage: 'History',
}
),
isSelected: selectedPageTab === 'history',
onClick: () => onSelectPageTab('history'),
},
{
label: i18n.translate(
'xpack.enterpriseSearch.appSearch.engine.curations.settingsPageTabLabel',
@ -74,6 +85,7 @@ export const Curations: React.FC = () => {
isLoading={dataLoading && !curations.length}
>
{selectedPageTab === 'overview' && <CurationsOverview />}
{selectedPageTab === 'history' && <CurationsHistory />}
{selectedPageTab === 'settings' && <CurationsSettings />}
</AppSearchPageTemplate>
);

22
x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/views/curations_history/components/curation_changes_panel.test.tsx Normal file
View file

@ -0,0 +1,22 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import React from 'react';
import { shallow } from 'enzyme';
import { DataPanel } from '../../../../data_panel';
import { CurationChangesPanel } from './curation_changes_panel';
describe('CurationChangesPanel', () => {
it('renders', () => {
const wrapper = shallow(<CurationChangesPanel />);
expect(wrapper.is(DataPanel)).toBe(true);
});
});

23
x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/views/curations_history/components/curation_changes_panel.tsx Normal file
View file

@ -0,0 +1,23 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import React from 'react';
import { DataPanel } from '../../../../data_panel';
export const CurationChangesPanel: React.FC = () => {
return (
<DataPanel
title={<h2>Automated curation changes</h2>}
subtitle={<span>A detailed log of recent changes to your automated curations</span>}
iconType="visTable"
hasBorder
>
Embedded logs view goes here...
</DataPanel>
);
};

25
x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/views/curations_history/components/ignored_suggestions_panel.test.tsx Normal file
View file

@ -0,0 +1,25 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import React from 'react';
import { shallow } from 'enzyme';
import { EuiBasicTable } from '@elastic/eui';
import { DataPanel } from '../../../../data_panel';
import { IgnoredSuggestionsPanel } from './ignored_suggestions_panel';
describe('IgnoredSuggestionsPanel', () => {
it('renders', () => {
const wrapper = shallow(<IgnoredSuggestionsPanel />);
expect(wrapper.is(DataPanel)).toBe(true);
expect(wrapper.find(EuiBasicTable)).toHaveLength(1);
});
});

53
x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/views/curations_history/components/ignored_suggestions_panel.tsx Normal file
View file

@ -0,0 +1,53 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import React from 'react';
import { CustomItemAction, EuiBasicTable, EuiBasicTableColumn, EuiLink } from '@elastic/eui';
import { DataPanel } from '../../../../data_panel';
import { CurationSuggestion } from '../../../types';
export const IgnoredSuggestionsPanel: React.FC = () => {
const ignoredSuggestions: CurationSuggestion[] = [];
const allowSuggestion = (query: string) => alert(query);
const actions: Array<CustomItemAction<CurationSuggestion>> = [
{
render: (item: CurationSuggestion) => {
return (
<EuiLink onClick={() => allowSuggestion(item.query)} color="primary">
Allow
</EuiLink>
);
},
},
];
const columns: Array<EuiBasicTableColumn<CurationSuggestion>> = [
{
field: 'query',
name: 'Query',
sortable: true,
},
{
actions,
},
];
return (
<DataPanel
title={<h2>Ignored queries</h2>}
subtitle={<span>You won’t be notified about suggestions for these queries</span>}
iconType="eyeClosed"
hasBorder
>
<EuiBasicTable items={ignoredSuggestions} itemId="query" columns={columns} />
</DataPanel>
);
};

10
x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/views/curations_history/components/index.ts Normal file
View file

@ -0,0 +1,10 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
export { CurationChangesPanel } from './curation_changes_panel';
export { IgnoredSuggestionsPanel } from './ignored_suggestions_panel';
export { RejectedCurationsPanel } from './rejected_curations_panel';

22
x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/views/curations_history/components/rejected_curations_panel.test.tsx Normal file
View file

@ -0,0 +1,22 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import React from 'react';
import { shallow } from 'enzyme';
import { DataPanel } from '../../../../data_panel';
import { RejectedCurationsPanel } from './rejected_curations_panel';
describe('RejectedCurationsPanel', () => {
it('renders', () => {
const wrapper = shallow(<RejectedCurationsPanel />);
expect(wrapper.is(DataPanel)).toBe(true);
});
});

23
x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/views/curations_history/components/rejected_curations_panel.tsx Normal file
View file

@ -0,0 +1,23 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import React from 'react';
import { DataPanel } from '../../../../data_panel';
export const RejectedCurationsPanel: React.FC = () => {
return (
<DataPanel
title={<h2>Rececntly rejected sugggestions</h2>}
subtitle={<span>Recent suggestions that are still valid can be re-enabled from here</span>}
iconType="crossInACircleFilled"
hasBorder
>
Embedded logs view goes here...
</DataPanel>
);
};

27
x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/views/curations_history/curations_history.test.tsx Normal file
View file

@ -0,0 +1,27 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import React from 'react';
import { shallow } from 'enzyme';
import {
CurationChangesPanel,
IgnoredSuggestionsPanel,
RejectedCurationsPanel,
} from './components';
import { CurationsHistory } from './curations_history';
describe('CurationsHistory', () => {
it('renders', () => {
const wrapper = shallow(<CurationsHistory />);
expect(wrapper.find(CurationChangesPanel)).toHaveLength(1);
expect(wrapper.find(RejectedCurationsPanel)).toHaveLength(1);
expect(wrapper.find(IgnoredSuggestionsPanel)).toHaveLength(1);
});
});

36
x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/views/curations_history/curations_history.tsx Normal file
View file

@ -0,0 +1,36 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import React from 'react';
import { EuiFlexGroup, EuiFlexItem } from '@elastic/eui';
import {
CurationChangesPanel,
IgnoredSuggestionsPanel,
RejectedCurationsPanel,
} from './components';
export const CurationsHistory: React.FC = () => {
return (
<EuiFlexGroup>
<EuiFlexItem grow={2}>
<EuiFlexGroup direction="column">
<EuiFlexItem>
<CurationChangesPanel />
</EuiFlexItem>
<EuiFlexItem>
<RejectedCurationsPanel />
</EuiFlexItem>
</EuiFlexGroup>
</EuiFlexItem>
<EuiFlexItem grow={1}>
<IgnoredSuggestionsPanel />
</EuiFlexItem>
</EuiFlexGroup>
);
};

8
x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/views/curations_history/index.ts Normal file
View file

@ -0,0 +1,8 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
export { CurationsHistory } from './curations_history';