[Code]: re-enable all certificate checks (#39634)

x-pack/legacy/plugins/code/server/__tests__/repository_service.ts

@@ -28,7 +28,7 @@ describe('repository service test', () => {
   after(() => {
     return rimraf.sync(baseDir);
   });
-  const service = new RepositoryService(repoDir, credsDir, log, false /* enableGitCertCheck */);
+  const service = new RepositoryService(repoDir, credsDir, log, true);
 
   it('can not clone a repo by ssh without a key', async () => {
     const repo = RepositoryUtils.buildRepository(

x-pack/legacy/plugins/code/server/queue/delete_worker.test.ts

@@ -75,7 +75,7 @@ test('Execute delete job.', async () => {
     esClient as EsClient,
     {
       security: {
-        enableGitCertCheck: false,
+        enableGitCertCheck: true,
       },
     } as ServerOptions,
     {} as GitOperations,

x-pack/legacy/plugins/code/server/queue/update_worker.test.ts

@@ -57,7 +57,7 @@ test('Execute update job', async () => {
     esClient as EsClient,
     {
       security: {
-        enableGitCertCheck: false,
+        enableGitCertCheck: true,
       },
     } as ServerOptions,
     {} as GitOperations,
@@ -97,7 +97,7 @@ test('On update job completed because of cancellation ', async () => {
     esClient as EsClient,
     {
       security: {
-        enableGitCertCheck: false,
+        enableGitCertCheck: true,
       },
     } as ServerOptions,
     {} as GitOperations,

x-pack/legacy/plugins/code/server/test_utils.ts

@@ -32,7 +32,7 @@ const TEST_OPTIONS = {
     enableMavenImport: true,
     enableGradleImport: true,
     installNodeDependency: true,
-    enableGitCertCheck: false,
+    enableGitCertCheck: true,
     gitProtocolWhitelist: ['ssh', 'https', 'git'],
   },
   repos: [],

x-pack/test/functional/config.js

@@ -199,7 +199,6 @@ export default async function ({ readConfigFile }) {
         '--stats.maximumWaitTimeForAllCollectorsInS=1',
         '--xpack.security.encryptionKey="wuGNaIhoMpk5sO4UBxgr3NyW1sFcLgIf"', // server restarts should not invalidate active sessions
         '--xpack.encrypted_saved_objects.encryptionKey="DkdXazszSCYexXqz4YktBGHCRkV6hyNK"',
-        '--xpack.code.security.enableGitCertCheck=false', // Disable git certificate check
         '--timelion.ui.enabled=true',
       ],
     },