maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[kbnArchiver] fix save to non-existent file (#101974) (#101981)

Browse source 
Co-authored-by: spalger <spalger@users.noreply.github.com>

Co-authored-by: Spencer <email@spalger.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
This commit is contained in:
Kibana Machine 2021-06-10 23:22:55 -04:00 committed by GitHub
parent edad104ca4
commit aaa983ea2a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
packages/kbn-test/src/kbn_client/kbn_client_import_export.ts
View file

@ -48,7 +48,12 @@ export class KbnClientImportExport {
path = `${path}.json`;
}
const absolutePath = Path.resolve(this.baseDir, path);
return Path.resolve(this.baseDir, path);
}
private resolveAndValidatePath(path: string) {
const absolutePath = this.resolvePath(path);
if (!existsSync(absolutePath)) {
throw new Error(
`unable to resolve path [${path}] to import/export, resolved relative to [${this.baseDir}]`
@ -59,7 +64,7 @@ export class KbnClientImportExport {
}
async load(path: string, options?: { space?: string }) {
const src = this.resolvePath(path);
const src = this.resolveAndValidatePath(path);
this.log.debug('resolved import for', path, 'to', src);
const objects = await parseArchive(src);
@ -94,7 +99,7 @@ export class KbnClientImportExport {
}
async unload(path: string, options?: { space?: string }) {
const src = this.resolvePath(path);
const src = this.resolveAndValidatePath(path);
this.log.debug('unloading docs from archive at', src);
const objects = await parseArchive(src);
@ -143,6 +148,7 @@ export class KbnClientImportExport {
})
.join('\n\n');
await Fs.mkdir(Path.dirname(dest), { recursive: true });
await Fs.writeFile(dest, fileContents, 'utf-8');
this.log.success('Exported', objects.length, 'saved objects to', dest);