[Lens] Only show copy on save for previously saved docs (#63535)
* [Lens] Only show copy on save for previously saved docs * Update app.test.tsx import after kibana platform changes Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com>
This commit is contained in:
parent
716211f2db
commit
ac549ac6f5
|
@ -12,6 +12,7 @@ import { EditorFrameInstance } from '../types';
|
|||
import { Storage } from '../../../../../src/plugins/kibana_utils/public';
|
||||
import { Document, SavedObjectStore } from '../persistence';
|
||||
import { mount } from 'enzyme';
|
||||
import { SavedObjectSaveModal } from '../../../../../src/plugins/saved_objects/public';
|
||||
import {
|
||||
esFilters,
|
||||
FilterManager,
|
||||
|
@ -650,6 +651,27 @@ describe('Lens App', () => {
|
|||
},
|
||||
});
|
||||
});
|
||||
|
||||
it('does not show the copy button on first save', async () => {
|
||||
const args = defaultArgs;
|
||||
args.editorFrame = frame;
|
||||
|
||||
instance = mount(<App {...args} />);
|
||||
|
||||
const onChange = frame.mount.mock.calls[0][1].onChange;
|
||||
await act(async () =>
|
||||
onChange({
|
||||
filterableIndexPatterns: [],
|
||||
doc: ({ expression: 'valid expression' } as unknown) as Document,
|
||||
})
|
||||
);
|
||||
instance.update();
|
||||
|
||||
await act(async () => getButton(instance).run(instance.getDOMNode()));
|
||||
instance.update();
|
||||
|
||||
expect(instance.find(SavedObjectSaveModal).prop('showCopyOnSave')).toEqual(false);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
|
|
|
@ -387,7 +387,7 @@ export function App({
|
|||
}}
|
||||
onClose={() => setState(s => ({ ...s, isSaveModalVisible: false }))}
|
||||
title={lastKnownDoc.title || ''}
|
||||
showCopyOnSave={!addToDashboardMode}
|
||||
showCopyOnSave={!!lastKnownDoc.id && !addToDashboardMode}
|
||||
objectType={i18n.translate('xpack.lens.app.saveModalType', {
|
||||
defaultMessage: 'Lens visualization',
|
||||
})}
|
||||
|
|
Loading…
Reference in a new issue