maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Dont record analytics when showing curations (#103558)

Browse source
This commit is contained in:
Jason Stoltzfus 2021-06-29 08:24:51 -04:00 committed by GitHub
parent 5aa8305279
commit af62b05e3a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/curation/curation_logic.test.ts
View file

@ -287,7 +287,10 @@ describe('CurationLogic', () => {
await nextTick();
expect(http.get).toHaveBeenCalledWith(
'/api/app_search/engines/some-engine/curations/cur-123456789'
'/api/app_search/engines/some-engine/curations/cur-123456789',
{
query: { skip_record_analytics: 'true' },
}
);
expect(CurationLogic.actions.onCurationLoad).toHaveBeenCalledWith(MOCK_CURATION_RESPONSE);
});

3
x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/curation/curation_logic.ts
View file

@ -169,7 +169,8 @@ export const CurationLogic = kea<MakeLogicType<CurationValues, CurationActions,
try {
const response = await http.get(
`/api/app_search/engines/${engineName}/curations/${props.curationId}`
`/api/app_search/engines/${engineName}/curations/${props.curationId}`,
{ query: { skip_record_analytics: 'true' } }
);
actions.onCurationLoad(response);
} catch (e) {

3
x-pack/plugins/enterprise_search/server/routes/app_search/curations.ts
View file

@ -67,6 +67,9 @@ export function registerCurationsRoutes({
{
path: '/api/app_search/engines/{engineName}/curations/{curationId}',
validate: {
query: schema.object({
skip_record_analytics: schema.string(),
}),
params: schema.object({
engineName: schema.string(),
curationId: schema.string(),