maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Metrics UI] Prevent saved views from trampling URL state (#103146)

Browse source 
* [Metrics UI] Prevent saved views from trampling URL state

* Adding space back in
This commit is contained in:
Chris Cowan 2021-06-24 14:13:15 -07:00 committed by GitHub
parent d5f68eef4f
commit b12095b079
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
x-pack/plugins/infra/public/containers/saved_view/saved_view.tsx
View file

@ -255,12 +255,21 @@ export const useSavedView = (props: Props) => {
}, [urlState, setUrlState, currentView, defaultViewId, data]);
useEffect(() => {
if (!currentView && !loading && data) {
if (!currentView && !loading && data && shouldLoadDefault) {
const viewToSet = views.find((v) => v.id === urlState.viewId);
if (viewToSet) setCurrentView(viewToSet);
else loadDefaultViewIfSet();
}
}, [loading, currentView, data, views, setCurrentView, loadDefaultViewIfSet, urlState.viewId]);
}, [
loading,
currentView,
data,
views,
setCurrentView,
loadDefaultViewIfSet,
urlState.viewId,
shouldLoadDefault,
]);
return {
views,