maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Stack Monitoring] functional tests - properly set test-subj attribute (#114491)

Browse source 
* properly set test-subj attribute

* fix prettier error

* Fixing ESLinting issue

Co-authored-by: Chris Cowan <chris@chriscowan.us>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Kevin Lacabane 2021-10-12 10:55:53 +02:00 committed by GitHub
parent 8ea719ca8a
commit b5771c81ba
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
x-pack/plugins/monitoring/public/application/pages/kibana/instance.tsx
View file

@ -164,13 +164,8 @@ export const KibanaInstancePage: React.FC<ComponentProps> = ({ clusters }) => {
}, [ccs, clusterUuid, instance, services.data?.query.timefilter.timefilter, services.http]);
return (
<PageTemplate
title={title}
pageTitle={pageTitle}
getPageData={getPageData}
data-test-subj="kibanaInstancePage"
>
<div data-test-subj="monitoringKibanaInstanceApp">
<PageTemplate title={title} pageTitle={pageTitle} getPageData={getPageData}>
<div data-test-subj="kibanaInstancePage">
<KibanaInstance data={data} alerts={alerts} />
</div>
</PageTemplate>

7
x-pack/plugins/monitoring/public/application/pages/kibana/instances.tsx
View file

@ -87,12 +87,7 @@ export const KibanaInstancesPage: React.FC<ComponentProps> = ({ clusters }) => {
]);
return (
<KibanaTemplate
title={title}
pageTitle={pageTitle}
getPageData={getPageData}
data-test-subj="kibanaInstancesPage"
>
<KibanaTemplate title={title} pageTitle={pageTitle} getPageData={getPageData}>
<div data-test-subj="monitoringKibanaInstancesApp">
<SetupModeRenderer
productName={KIBANA_SYSTEM_ID}

2
x-pack/plugins/monitoring/public/application/pages/kibana/kibana_template.tsx
View file

@ -16,6 +16,7 @@ export const KibanaTemplate: React.FC<PageTemplateProps> = ({ ...props }) => {
defaultMessage: 'Overview',
}),
route: '/kibana',
testSubj: 'kibanaOverviewPage',
},
{
id: 'instances',
@ -23,6 +24,7 @@ export const KibanaTemplate: React.FC<PageTemplateProps> = ({ ...props }) => {
defaultMessage: 'Instances',
}),
route: '/kibana/instances',
testSubj: 'kibanaInstancesPage',
},
];

7
x-pack/plugins/monitoring/public/application/pages/kibana/overview.tsx
View file

@ -107,12 +107,7 @@ export const KibanaOverviewPage: React.FC<ComponentProps> = ({ clusters }) => {
}, [ccs, clusterUuid, services.data?.query.timefilter.timefilter, services.http]);
return (
<KibanaTemplate
data-test-subj="kibanaOverviewPage"
getPageData={getPageData}
title={title}
pageTitle={pageTitle}
>
<KibanaTemplate getPageData={getPageData} title={title} pageTitle={pageTitle}>
<KibanaOverview data={data} />
</KibanaTemplate>
);