maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

include and fix hello world example test (#108072) (#108264)

Browse source
This commit is contained in:
Anton Dosov 2021-08-11 23:17:49 +02:00 committed by GitHub
parent e792ea93d6
commit b58d14467e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
examples/hello_world/public/plugin.tsx
View file

@ -21,7 +21,7 @@ export class HelloWorldPlugin implements Plugin<void, void, SetupDeps> {
id: 'helloWorld',
title: 'Hello World',
async mount({ element }: AppMountParameters) {
ReactDOM.render(<div id="helloWorldDiv">Hello World!</div>, element);
ReactDOM.render(<div data-test-subj="helloWorldDiv">Hello World!</div>, element);
return () => ReactDOM.unmountComponentAtNode(element);
},
});

1
test/examples/config.js
View file

@ -22,6 +22,7 @@ export default async function ({ readConfigFile }) {
return {
testFiles: [
require.resolve('./hello_world'),
require.resolve('./embeddables'),
require.resolve('./bfetch_explorer'),
require.resolve('./ui_actions'),