From b86c1c4aea5f14a020d9d328c779923161c5f67e Mon Sep 17 00:00:00 2001 From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Date: Wed, 6 Oct 2021 13:38:58 -0400 Subject: [PATCH] [vscode] Set typescript.tsserver.maxTsServerMemory (#113959) (#114124) Signed-off-by: Tyler Smalley Co-authored-by: Tyler Smalley --- .../src/vscode_config/managed_config_keys.ts | 6 +++++- .../src/vscode_config/update_vscode_config.ts | 14 +++++++------- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/packages/kbn-dev-utils/src/vscode_config/managed_config_keys.ts b/packages/kbn-dev-utils/src/vscode_config/managed_config_keys.ts index 07156ca9257f..f5bee0ce67fe 100644 --- a/packages/kbn-dev-utils/src/vscode_config/managed_config_keys.ts +++ b/packages/kbn-dev-utils/src/vscode_config/managed_config_keys.ts @@ -8,7 +8,7 @@ export interface ManagedConfigKey { key: string; - value: string | Record | boolean; + value: string | Record | boolean | number; } /** @@ -46,4 +46,8 @@ export const MANAGED_CONFIG_KEYS: ManagedConfigKey[] = [ key: 'typescript.enablePromptUseWorkspaceTsdk', value: true, }, + { + key: 'typescript.tsserver.maxTsServerMemory', + value: 4096, + }, ]; diff --git a/packages/kbn-dev-utils/src/vscode_config/update_vscode_config.ts b/packages/kbn-dev-utils/src/vscode_config/update_vscode_config.ts index b337c8baa5e3..5c33b00262cc 100644 --- a/packages/kbn-dev-utils/src/vscode_config/update_vscode_config.ts +++ b/packages/kbn-dev-utils/src/vscode_config/update_vscode_config.ts @@ -69,13 +69,13 @@ const createObjectPropOfManagedValues = (key: string, value: Record const addManagedProp = ( ast: t.ObjectExpression, key: string, - value: string | Record | boolean + value: string | Record | boolean | number ) => { - ast.properties.push( - typeof value === 'string' || typeof value === 'boolean' - ? createManagedProp(key, value) - : createObjectPropOfManagedValues(key, value) - ); + if (['number', 'string', 'boolean'].includes(typeof value)) { + ast.properties.push(createManagedProp(key, value)); + } else { + ast.properties.push(createObjectPropOfManagedValues(key, value as Record)); + } }; /** @@ -89,7 +89,7 @@ const addManagedProp = ( const replaceManagedProp = ( ast: t.ObjectExpression, existing: BasicObjectProp, - value: string | Record | boolean + value: string | Record | boolean | number ) => { remove(ast.properties, existing); addManagedProp(ast, existing.key.value, value);