maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

unskipping interpreter functional tests (#40840)

Browse source
This commit is contained in:
Peter Pisljar 2019-07-11 14:37:21 +02:00 committed by GitHub
parent 842cf67ecd
commit b8709e1e86
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

BIN
test/interpreter_functional/screenshots/baseline/partial_test_1.png
View file

Binary file not shown.
Side by side Swipe Overlay

Before

Width:  |  Height:  |  Size: 12 KiB

After

Width:  |  Height:  |  Size: 11 KiB

BIN
test/interpreter_functional/screenshots/baseline/partial_test_2.png
View file

Binary file not shown.
Side by side Swipe Overlay

Before

Width:  |  Height:  |  Size: 12 KiB

After

Width:  |  Height:  |  Size: 16 KiB

BIN
test/interpreter_functional/screenshots/baseline/partial_test_3.png
View file

Binary file not shown.
Side by side Swipe Overlay

Before

Width:  |  Height:  |  Size: 14 KiB

After

Width:  |  Height:  |  Size: 6.9 KiB

13
test/interpreter_functional/test_suites/run_pipeline/basic.js
View file

@ -82,7 +82,7 @@ export default function ({ getService, updateBaselines }) {
// if we want to do multiple different tests using the same data, or reusing a part of expression its
// possible to retrieve the intermediate result and reuse it in later expressions
describe.skip('reusing partial results', () => {
describe('reusing partial results', () => {
it ('does some screenshot comparisons', async () => {
const expression = `kibana | kibana_context | esaggs index='logstash-*' aggConfigs='[
{"id":"1","enabled":true,"type":"count","schema":"metric","params":{}},
@ -94,16 +94,17 @@ export default function ({ getService, updateBaselines }) {
// we reuse that response to render 3 different charts and compare screenshots with baselines
const tagCloudExpr =
`tagcloud metric={visdimension 1 format="number"} bucket={visdimension 0}'`;
`tagcloud metric={visdimension 1 format="number"} bucket={visdimension 0}`;
await expectExpression('partial_test_1', tagCloudExpr, context).toMatchScreenshot();
const metricExpr =
`metricVis metric={visdimension 1 format="number"} bucket={visdimension 0}'`;
`metricVis metric={visdimension 1 format="number"} bucket={visdimension 0}`;
await expectExpression('partial_test_2', metricExpr, context).toMatchScreenshot();
const regionMapExpr =
`regionmap visConfig='{"metric":{"accessor":1,"format":{"id":"number"}},"bucket":{"accessor":0}}'`;
await expectExpression('partial_test_3', regionMapExpr, context).toMatchScreenshot();
// todo: regionmap doesn't correctly signal when its done rendering (base layer might not yet be loaded)
// const regionMapExpr =
// `regionmap visConfig='{"metric":{"accessor":1,"format":{"id":"number"}},"bucket":{"accessor":0}}'`;
// await expectExpression('partial_test_3', regionMapExpr, context).toMatchScreenshot();
});
});
});