maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Maps] fix term join not updating when editing right field (#111030)

Browse source 
* [Maps] fix term join not updating when editing right field

* tslint

* clean up

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Nathan Reese 2021-09-07 10:18:22 -06:00 committed by GitHub
parent b5f8d2e998
commit b8faf091c9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 26 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
x-pack/plugins/maps/common/descriptor_types/data_request_descriptor_types.ts
View file

@ -12,6 +12,7 @@ import { SortDirection } from 'src/plugins/data/common/search';
import { RENDER_AS, SCALING_TYPES } from '../constants';
import { MapExtent, MapQuery } from './map_descriptor';
import { Filter, TimeRange } from '../../../../../src/plugins/data/common';
import { ESTermSourceDescriptor } from './source_descriptor_types';
export type Timeslice = {
from: number;
@ -50,9 +51,7 @@ type ESGeoLineSourceSyncMeta = {
sortField: string;
};
type ESTermSourceSyncMeta = {
size: number;
};
export type ESTermSourceSyncMeta = Pick<ESTermSourceDescriptor, 'indexPatternId' | 'size' | 'term'>;
export type VectorSourceSyncMeta =
| ESSearchSourceSyncMeta

17
x-pack/plugins/maps/public/classes/sources/es_term_source/es_term_source.test.js
View file

@ -109,3 +109,20 @@ describe('extractPropertiesMap', () => {
expect(properties[minPropName]).toBe(0);
});
});
describe('getSyncMeta', () => {
it('should contain meta requiring source re-fetch when changed', () => {
const source = new ESTermSource({
id: '1234',
indexPatternTitle: indexPatternTitle,
term: termFieldName,
indexPatternId: 'foobar',
size: 10,
});
expect(source.getSyncMeta()).toEqual({
indexPatternId: 'foobar',
size: 10,
term: 'myTermField',
});
});
});

14
x-pack/plugins/maps/public/classes/sources/es_term_source/es_term_source.ts
View file

@ -25,8 +25,8 @@ import {
} from '../../../../common/elasticsearch_util';
import {
ESTermSourceDescriptor,
ESTermSourceSyncMeta,
VectorJoinSourceRequestMeta,
VectorSourceSyncMeta,
} from '../../../../common/descriptor_types';
import { Adapters } from '../../../../../../../src/plugins/inspector/common/adapters';
import { PropertiesMap } from '../../../../common/elasticsearch_util';
@ -171,12 +171,12 @@ export class ESTermSource extends AbstractESAggSource implements ITermJoinSource
return this.getMetricFields().map((esAggMetricField) => esAggMetricField.getName());
}
getSyncMeta(): VectorSourceSyncMeta | null {
return this._descriptor.size !== undefined
? {
size: this._descriptor.size,
}
: null;
getSyncMeta(): ESTermSourceSyncMeta | null {
return {
indexPatternId: this._descriptor.indexPatternId,
size: this._descriptor.size,
term: this._descriptor.term,
};
}
getRightFields(): IField[] {