From ba2b3b17140cdc4731c8b3f71da35594cea1f881 Mon Sep 17 00:00:00 2001 From: Nathan Reese Date: Tue, 13 Mar 2018 12:03:29 -0600 Subject: [PATCH] upgrade EUI to 0.0.26 (#17110) (#17126) * upgrade EUI to 0.0.25 * remove last reference to TooltipTrigger * upgraded to EUI 0.0.26 * fix warning, EuiKeyboardAccessible child must have onClick defined --- package.json | 2 +- .../__tests__/indexed_fields_table.test.js | 1 - .../__snapshots__/table.test.js.snap | 34 +++++-------------- .../components/table/table.js | 10 +++--- .../public/components/metric_vis_value.js | 2 +- src/ui/public/styles/base.less | 1 + yarn.lock | 6 ++-- 7 files changed, 19 insertions(+), 37 deletions(-) diff --git a/package.json b/package.json index 83611f30d268..fea064d2ea4e 100644 --- a/package.json +++ b/package.json @@ -75,7 +75,7 @@ "url": "https://github.com/elastic/kibana.git" }, "dependencies": { - "@elastic/eui": "0.0.23", + "@elastic/eui": "0.0.26", "@elastic/filesaver": "1.1.2", "@elastic/numeral": "2.3.1", "@elastic/ui-ace": "0.2.3", diff --git a/src/core_plugins/kibana/public/management/sections/indices/edit_index_pattern/indexed_fields_table/__tests__/indexed_fields_table.test.js b/src/core_plugins/kibana/public/management/sections/indices/edit_index_pattern/indexed_fields_table/__tests__/indexed_fields_table.test.js index 01d8f9dab709..7ee41b60755d 100644 --- a/src/core_plugins/kibana/public/management/sections/indices/edit_index_pattern/indexed_fields_table/__tests__/indexed_fields_table.test.js +++ b/src/core_plugins/kibana/public/management/sections/indices/edit_index_pattern/indexed_fields_table/__tests__/indexed_fields_table.test.js @@ -8,7 +8,6 @@ jest.mock('@elastic/eui', () => ({ EuiFlexItem: 'eui-flex-item', EuiIcon: 'eui-icon', EuiInMemoryTable: 'eui-in-memory-table', - TooltipTrigger: 'tooltip-trigger' })); jest.mock('../components/table', () => ({ diff --git a/src/core_plugins/kibana/public/management/sections/indices/edit_index_pattern/indexed_fields_table/components/table/__tests__/__snapshots__/table.test.js.snap b/src/core_plugins/kibana/public/management/sections/indices/edit_index_pattern/indexed_fields_table/components/table/__tests__/__snapshots__/table.test.js.snap index 980370d081a7..816c181dbdc3 100644 --- a/src/core_plugins/kibana/public/management/sections/indices/edit_index_pattern/indexed_fields_table/components/table/__tests__/__snapshots__/table.test.js.snap +++ b/src/core_plugins/kibana/public/management/sections/indices/edit_index_pattern/indexed_fields_table/components/table/__tests__/__snapshots__/table.test.js.snap @@ -22,25 +22,16 @@ exports[`Table should render conflicting type 1`] = ` component="div" grow={true} > - - + @@ -220,25 +211,16 @@ exports[`Table should render timestamp field name 1`] = ` component="div" grow={true} > - - + diff --git a/src/core_plugins/kibana/public/management/sections/indices/edit_index_pattern/indexed_fields_table/components/table/table.js b/src/core_plugins/kibana/public/management/sections/indices/edit_index_pattern/indexed_fields_table/components/table/table.js index 191e7668e67a..f9aff8c1005b 100644 --- a/src/core_plugins/kibana/public/management/sections/indices/edit_index_pattern/indexed_fields_table/components/table/table.js +++ b/src/core_plugins/kibana/public/management/sections/indices/edit_index_pattern/indexed_fields_table/components/table/table.js @@ -6,7 +6,7 @@ import { EuiFlexItem, EuiIcon, EuiInMemoryTable, - TooltipTrigger + EuiToolTip, } from '@elastic/eui'; export class Table extends PureComponent { @@ -29,9 +29,9 @@ export class Table extends PureComponent { {isTimeField ? ( - + - + ) : ''} @@ -48,9 +48,9 @@ export class Table extends PureComponent { {isConflict ? ( - + - + ) : ''} diff --git a/src/core_plugins/metric_vis/public/components/metric_vis_value.js b/src/core_plugins/metric_vis/public/components/metric_vis_value.js index 748d1e7a3b29..4d2d52107e23 100644 --- a/src/core_plugins/metric_vis/public/components/metric_vis_value.js +++ b/src/core_plugins/metric_vis/public/components/metric_vis_value.js @@ -31,7 +31,7 @@ class MetricVisValue extends Component {
{}} tabIndex={hasFilter ? 0 : null} role={hasFilter ? 'button' : null} > diff --git a/src/ui/public/styles/base.less b/src/ui/public/styles/base.less index 9d867f15475d..efd3e56d65e9 100644 --- a/src/ui/public/styles/base.less +++ b/src/ui/public/styles/base.less @@ -60,6 +60,7 @@ ul.navbar-inline li { .content { .real-flex-parent(@flow: row nowrap); width: 100%; + min-height: 100vh; height: 100%; overflow: hidden; diff --git a/yarn.lock b/yarn.lock index fb6dc89e6c4a..eb4cb17bdac1 100644 --- a/yarn.lock +++ b/yarn.lock @@ -81,9 +81,9 @@ version "0.0.0" uid "" -"@elastic/eui@0.0.23": - version "0.0.23" - resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-0.0.23.tgz#01a3d88aeaff175da5d42b70d407d08a32783f3d" +"@elastic/eui@0.0.26": + version "0.0.26" + resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-0.0.26.tgz#368beede3bb36b60879e2d7b5035e8d56e80b6e6" dependencies: brace "^0.10.0" classnames "^2.2.5"