maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Reporting] Re-enabled Chromium API tests (#26789)

Browse source 
* [Reporting] Test logging

* chromium api tests fixed

* whitespace
This commit is contained in:
Tim Sullivan 2018-12-07 09:27:19 -07:00 committed by GitHub
parent 339e38b96a
commit ba82bc2f59
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 20 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
x-pack/plugins/reporting/server/routes/jobs.js
View file

@ -124,6 +124,16 @@ export function jobs(server) {
const { docId } = request.params;
let response = await jobResponseHandler(request.pre.management.jobTypes, request.pre.user, h, { docId });
const { statusCode } = response;
if (statusCode !== 200) {
const logLevel = statusCode === 500 ? 'error' : 'debug';
server.log(
[logLevel, "reporting", "download"],
`Report ${docId} has non-OK status: [${statusCode}] Reason: [${JSON.stringify(response.source)}]`
);
}
if (!response.isBoom) {
response = response.header('accept-ranges', 'none');
}

2
x-pack/scripts/functional_tests.js
View file

@ -6,7 +6,7 @@
require('@kbn/plugin-helpers').babelRegister();
require('@kbn/test').runTestsCli([
// require.resolve('../test/reporting/configs/chromium_api.js'),
require.resolve('../test/reporting/configs/chromium_api.js'),
// require.resolve('../test/reporting/configs/chromium_functional.js'),
// require.resolve('../test/reporting/configs/phantom_api.js'),
// require.resolve('../test/reporting/configs/phantom_functional.js'),

1
x-pack/test/reporting/configs/api.js
View file

@ -30,6 +30,7 @@ export async function getReportingApiConfig({ readConfigFile }) {
serverArgs: [
...apiConfig.get('kbnTestServer.serverArgs'),
`--optimize.enabled=true`,
'--logging.events.log', JSON.stringify(['info', 'warning', 'error', 'fatal', 'optimize', 'reporting'])
],
},
};

1
x-pack/test/reporting/configs/chromium_api.js
View file

@ -22,7 +22,6 @@ export default async function ({ readConfigFile }) {
...reportingApiConfig.kbnTestServer.serverArgs,
`--xpack.reporting.capture.browser.type=chromium`,
`--xpack.spaces.enabled=false`,
`--logging.verbose=true`,
],
},
};

10
x-pack/test/reporting/configs/functional.js
View file

@ -21,9 +21,15 @@ export async function getFunctionalConfig({ readConfigFile }) {
junit: {
reportName: 'X-Pack Reporting Functional Tests',
},
kbnTestServer: xPackFunctionalTestsConfig.get('kbnTestServer'),
kbnTestServer: {
...xPackFunctionalTestsConfig.get('kbnTestServer'),
serverArgs: [
...xPackFunctionalTestsConfig.get('kbnTestServer.serverArgs'),
'--logging.events.log', JSON.stringify(['info', 'warning', 'error', 'fatal', 'optimize', 'reporting'])
],
},
testFiles: [require.resolve('../functional')],
};
}
export default getFunctionalConfig;
export default getFunctionalConfig;

1
x-pack/test/reporting/configs/phantom_functional.js
View file

@ -21,7 +21,6 @@ export default async function ({ readConfigFile }) {
serverArgs: [
...functionalConfig.kbnTestServer.serverArgs,
`--xpack.reporting.capture.browser.type=phantom`,
`--logging.verbose=true`,
],
},
};