[Canvas] Disable embeddables in canvas (#48102) (#48223)

* Disable embeddables in canvas
This commit is contained in:
Corey Robertson 2019-10-15 14:57:48 -04:00 committed by GitHub
parent 7662c6b194
commit baeb7d4d25
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 18 additions and 7 deletions

View file

@ -47,9 +47,10 @@ import { rounddate } from './rounddate';
import { rowCount } from './rowCount';
import { repeatImage } from './repeatImage';
import { revealImage } from './revealImage';
import { savedMap } from './saved_map';
import { savedSearch } from './saved_search';
import { savedVisualization } from './saved_visualization';
// TODO: elastic/kibana#44822 Disabling pending filters work
// import { savedMap } from './saved_map';
// import { savedSearch } from './saved_search';
// import { savedVisualization } from './saved_visualization';
import { seriesStyle } from './seriesStyle';
import { shape } from './shape';
import { sort } from './sort';
@ -106,9 +107,10 @@ export const functions = [
revealImage,
rounddate,
rowCount,
savedMap,
savedSearch,
savedVisualization,
// TODO: elastic/kibana#44822 Disabling pending filters work
// savedMap,
// savedSearch,
// savedVisualization,
seriesStyle,
shape,
sort,

View file

@ -35,6 +35,7 @@ interface SavedMapInput extends EmbeddableInput {
type Return = EmbeddableExpression<SavedMapInput>;
export function savedMap(): ExpressionFunction<'savedMap', Filter | null, Arguments, Return> {
// @ts-ignore elastic/kibana#44822 Disabling pending filters work
const { help, args: argHelp } = getFunctionHelp().savedMap;
return {
name: 'savedMap',

View file

@ -23,6 +23,7 @@ interface Arguments {
type Return = EmbeddableExpression<Partial<SearchInput> & { id: SearchInput['id'] }>;
export function savedSearch(): ExpressionFunction<'savedSearch', Filter | null, Arguments, Return> {
// @ts-ignore elastic/kibana#44822 Disabling pending filters work
const { help, args: argHelp } = getFunctionHelp().savedSearch;
return {
name: 'savedSearch',

View file

@ -26,6 +26,7 @@ export function savedVisualization(): ExpressionFunction<
Arguments,
Return
> {
// @ts-ignore elastic/kibana#44822 Disabling pending filters work
const { help, args: argHelp } = getFunctionHelp().savedVisualization;
return {
name: 'savedVisualization',

View file

@ -207,8 +207,12 @@ export const getFunctionHelp = (): FunctionHelpDict => ({
revealImage,
rounddate,
rowCount,
// TODO: elastic/kibana#44822 Disabling pending filters work
// @ts-ignore
savedMap,
// @ts-ignore
savedSearch,
// @ts-ignore
savedVisualization,
seriesStyle,
shape,

View file

@ -13,7 +13,6 @@ import {
EuiFlexGroup,
EuiButtonIcon,
EuiButton,
EuiButtonEmpty,
EuiOverlayMask,
EuiModal,
EuiModalFooter,
@ -194,11 +193,14 @@ export class WorkpadHeader extends React.PureComponent<Props, State> {
<EuiFlexItem grow={false}>
<AssetManager />
</EuiFlexItem>
{/*
TODO: elastic/kibana#44822 Disabling pending filters work
<EuiFlexItem grow={false}>
<EuiButtonEmpty onClick={this._showEmbeddablePanel}>
{strings.getEmbedObjectButtonLabel()}
</EuiButtonEmpty>
</EuiFlexItem>
*/}
<EuiFlexItem grow={false}>
<EuiButton
fill