[Canvas] Disable embeddables in canvas (#48102) (#48223)

* Disable embeddables in canvas
This commit is contained in:
Corey Robertson 2019-10-15 14:57:48 -04:00 committed by GitHub
parent 7662c6b194
commit baeb7d4d25
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 18 additions and 7 deletions

View file

@ -47,9 +47,10 @@ import { rounddate } from './rounddate';
import { rowCount } from './rowCount'; import { rowCount } from './rowCount';
import { repeatImage } from './repeatImage'; import { repeatImage } from './repeatImage';
import { revealImage } from './revealImage'; import { revealImage } from './revealImage';
import { savedMap } from './saved_map'; // TODO: elastic/kibana#44822 Disabling pending filters work
import { savedSearch } from './saved_search'; // import { savedMap } from './saved_map';
import { savedVisualization } from './saved_visualization'; // import { savedSearch } from './saved_search';
// import { savedVisualization } from './saved_visualization';
import { seriesStyle } from './seriesStyle'; import { seriesStyle } from './seriesStyle';
import { shape } from './shape'; import { shape } from './shape';
import { sort } from './sort'; import { sort } from './sort';
@ -106,9 +107,10 @@ export const functions = [
revealImage, revealImage,
rounddate, rounddate,
rowCount, rowCount,
savedMap, // TODO: elastic/kibana#44822 Disabling pending filters work
savedSearch, // savedMap,
savedVisualization, // savedSearch,
// savedVisualization,
seriesStyle, seriesStyle,
shape, shape,
sort, sort,

View file

@ -35,6 +35,7 @@ interface SavedMapInput extends EmbeddableInput {
type Return = EmbeddableExpression<SavedMapInput>; type Return = EmbeddableExpression<SavedMapInput>;
export function savedMap(): ExpressionFunction<'savedMap', Filter | null, Arguments, Return> { export function savedMap(): ExpressionFunction<'savedMap', Filter | null, Arguments, Return> {
// @ts-ignore elastic/kibana#44822 Disabling pending filters work
const { help, args: argHelp } = getFunctionHelp().savedMap; const { help, args: argHelp } = getFunctionHelp().savedMap;
return { return {
name: 'savedMap', name: 'savedMap',

View file

@ -23,6 +23,7 @@ interface Arguments {
type Return = EmbeddableExpression<Partial<SearchInput> & { id: SearchInput['id'] }>; type Return = EmbeddableExpression<Partial<SearchInput> & { id: SearchInput['id'] }>;
export function savedSearch(): ExpressionFunction<'savedSearch', Filter | null, Arguments, Return> { export function savedSearch(): ExpressionFunction<'savedSearch', Filter | null, Arguments, Return> {
// @ts-ignore elastic/kibana#44822 Disabling pending filters work
const { help, args: argHelp } = getFunctionHelp().savedSearch; const { help, args: argHelp } = getFunctionHelp().savedSearch;
return { return {
name: 'savedSearch', name: 'savedSearch',

View file

@ -26,6 +26,7 @@ export function savedVisualization(): ExpressionFunction<
Arguments, Arguments,
Return Return
> { > {
// @ts-ignore elastic/kibana#44822 Disabling pending filters work
const { help, args: argHelp } = getFunctionHelp().savedVisualization; const { help, args: argHelp } = getFunctionHelp().savedVisualization;
return { return {
name: 'savedVisualization', name: 'savedVisualization',

View file

@ -207,8 +207,12 @@ export const getFunctionHelp = (): FunctionHelpDict => ({
revealImage, revealImage,
rounddate, rounddate,
rowCount, rowCount,
// TODO: elastic/kibana#44822 Disabling pending filters work
// @ts-ignore
savedMap, savedMap,
// @ts-ignore
savedSearch, savedSearch,
// @ts-ignore
savedVisualization, savedVisualization,
seriesStyle, seriesStyle,
shape, shape,

View file

@ -13,7 +13,6 @@ import {
EuiFlexGroup, EuiFlexGroup,
EuiButtonIcon, EuiButtonIcon,
EuiButton, EuiButton,
EuiButtonEmpty,
EuiOverlayMask, EuiOverlayMask,
EuiModal, EuiModal,
EuiModalFooter, EuiModalFooter,
@ -194,11 +193,14 @@ export class WorkpadHeader extends React.PureComponent<Props, State> {
<EuiFlexItem grow={false}> <EuiFlexItem grow={false}>
<AssetManager /> <AssetManager />
</EuiFlexItem> </EuiFlexItem>
{/*
TODO: elastic/kibana#44822 Disabling pending filters work
<EuiFlexItem grow={false}> <EuiFlexItem grow={false}>
<EuiButtonEmpty onClick={this._showEmbeddablePanel}> <EuiButtonEmpty onClick={this._showEmbeddablePanel}>
{strings.getEmbedObjectButtonLabel()} {strings.getEmbedObjectButtonLabel()}
</EuiButtonEmpty> </EuiButtonEmpty>
</EuiFlexItem> </EuiFlexItem>
*/}
<EuiFlexItem grow={false}> <EuiFlexItem grow={false}>
<EuiButton <EuiButton
fill fill