maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Disable in-chart "Explore underlying data" by default (#74332)

Browse source 
* fix: 🐛 disable in-chart "Explore underlying data" by default

* test: 💍 disable in-chart action functional test suite

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This commit is contained in:
Vadim Dalecky 2020-08-06 15:07:14 +02:00 committed by GitHub
parent 9186171ad1
commit bbfc4922d2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
docs/drilldowns/explore-underlying-data.asciidoc
View file

@ -33,9 +33,9 @@ applies the filters and time range created by the events that triggered the acti
[role="screenshot"]
image::images/explore_data_in_chart.png[Explore underlying data from chart]
You can disable this action by adding the following line to your `kibana.yml` config.
To enable this action add the following line to your `kibana.yml` config.
["source","yml"]
-----------
xpack.discoverEnhanced.actions.exploreDataInChart.enabled: false
xpack.discoverEnhanced.actions.exploreDataInChart.enabled: true
-----------

2
x-pack/plugins/discover_enhanced/server/config.ts
View file

@ -10,7 +10,7 @@ import { PluginConfigDescriptor } from '../../../../src/core/server';
export const configSchema = schema.object({
actions: schema.object({
exploreDataInChart: schema.object({
enabled: schema.boolean({ defaultValue: true }),
enabled: schema.boolean({ defaultValue: false }),
}),
}),
});

5
x-pack/test/functional/apps/dashboard/drilldowns/index.ts
View file

@ -24,6 +24,9 @@ export default function ({ loadTestFile, getService }: FtrProviderContext) {
loadTestFile(require.resolve('./dashboard_drilldowns'));
loadTestFile(require.resolve('./explore_data_panel_action'));
loadTestFile(require.resolve('./explore_data_chart_action'));
// Disabled for now as it requires xpack.discoverEnhanced.actions.exploreDataInChart.enabled
// setting set in kibana.yml to work. Once that is enabled by default, we can re-enable this test suite.
// loadTestFile(require.resolve('./explore_data_chart_action'));
});
}