maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix confirm overwrite modal of saved objects to handle large titles (#28590)

Browse source
This commit is contained in:
Mike Côté 2019-01-17 07:23:38 -08:00 committed by GitHub
parent 9a8d5d0ebb
commit bd4d9618a8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/ui/public/courier/saved_object/saved_object.js
View file

@ -324,9 +324,12 @@ export function SavedObjectProvider(Promise, Private, Notifier, confirmModalProm
return confirmModalPromise(confirmMessage, {
confirmButtonText: i18n.translate('common.ui.courier.savedObject.confirmModal.overwriteButtonLabel', {
defaultMessage: 'Overwrite {name}',
defaultMessage: 'Overwrite',
}),
title: i18n.translate('common.ui.courier.savedObject.confirmModal.overwriteTitle', {
defaultMessage: 'Overwrite {name}?',
values: { name: this.getDisplayName() }
})
}),
})
.then(() => savedObjectsClient.create(esType, source, this.creationOpts({ overwrite: true })))
.catch(() => Promise.reject(new Error(OVERWRITE_REJECTED)));

10
src/ui/public/index_patterns/_index_pattern.js
View file

@ -444,8 +444,14 @@ export function IndexPatternProvider(Private, config, Promise, confirmModalPromi
await confirmModalPromise(
i18n.translate('common.ui.indexPattern.confirmOverwriteLabel', { values: { title: this.title },
defaultMessage: 'Are you sure you want to overwrite \'{title}\'?' }),
{ confirmButtonText: i18n.translate('common.ui.indexPattern.confirmOverwriteButton', { defaultMessage: 'Overwrite' })
});
{
title: i18n.translate('common.ui.indexPattern.confirmOverwriteTitle', {
defaultMessage: 'Overwrite {type}?',
values: { type },
}),
confirmButtonText: i18n.translate('common.ui.indexPattern.confirmOverwriteButton', { defaultMessage: 'Overwrite' }),
}
);
} catch (err) {
// They changed their mind
return false;