[kbn-plugin-helpers] move jest tests to integration suite (#23005) (#23012)

The plugin helper tests have failed due to timeouts every once and a while, which makes sense because they run a bunch of CLI tasks, so this just moved them to the jest integration tests where tests can take a little longer to run.

packages/kbn-plugin-helpers/tasks/build/integration_tests/build_action.test.js

@@ -23,11 +23,11 @@ const del = require('del');
 
 const PLUGIN_FIXTURE = resolve(__dirname, '__fixtures__/build_action_test_plugin');
 const PLUGIN_BUILD_DIR = resolve(PLUGIN_FIXTURE, 'build');
-const PLUGIN = require('../../lib/plugin_config')(PLUGIN_FIXTURE);
+const PLUGIN = require('../../../lib/plugin_config')(PLUGIN_FIXTURE);
 const noop = () => {};
 
 describe('creating build zip', () => {
-  const buildAction = require('./build_action');
+  const buildAction = require('../build_action');
 
   beforeEach(() => del(PLUGIN_BUILD_DIR));
   afterEach(() => del(PLUGIN_BUILD_DIR));
@@ -58,8 +58,16 @@ describe('calling create_build', () => {
   beforeEach(() => {
     jest.resetModules();
     mockBuild = jest.fn(() => Promise.resolve());
-    jest.mock('./create_build', () => mockBuild);
-    buildAction = require('./build_action');
+    jest.mock('../create_build', () => mockBuild);
+    buildAction = require('../build_action');
+  });
+
+  const nameArgs = ([plugin, buildTarget, buildVersion, kibanaVersion, files]) => ({
+    plugin,
+    buildTarget,
+    buildVersion,
+    kibanaVersion,
+    files,
   });
 
   it('takes optional build version', async () => {
@@ -71,8 +79,8 @@ describe('calling create_build', () => {
     await buildAction(PLUGIN, noop, options);
 
     expect(mockBuild.mock.calls).toHaveLength(1);
-    // eslint-disable-next-line no-unused-vars
-    const [ plugin, buildTarget, buildVersion, kibanaVersion, files ] = mockBuild.mock.calls[0];
+
+    const { buildVersion, kibanaVersion } = nameArgs(mockBuild.mock.calls[0]);
     expect(buildVersion).toBe('1.2.3');
     expect(kibanaVersion).toBe('4.5.6');
   });
@@ -81,8 +89,8 @@ describe('calling create_build', () => {
     await buildAction(PLUGIN);
 
     expect(mockBuild.mock.calls).toHaveLength(1);
-    // eslint-disable-next-line no-unused-vars
-    const [ plugin, buildTarget, buildVersion, kibanaVersion, files ] = mockBuild.mock.calls[0];
+
+    const { files } = nameArgs(mockBuild.mock.calls[0]);
     PLUGIN.buildSourcePatterns.forEach(file => expect(files).toContain(file));
   });
 
@@ -99,8 +107,8 @@ describe('calling create_build', () => {
     await buildAction(PLUGIN, noop, options);
 
     expect(mockBuild.mock.calls).toHaveLength(1);
-    // eslint-disable-next-line no-unused-vars
-    const [ plugin, buildTarget, buildVersion, kibanaVersion, files ] = mockBuild.mock.calls[0];
+
+    const { files } = nameArgs(mockBuild.mock.calls[0]);
     options.files.forEach(file => expect(files).toContain(file));
   });
 

packages/kbn-plugin-helpers/tasks/build/integration_tests/create_build.test.js

@@ -20,10 +20,10 @@
 const { resolve } = require('path');
 const { readdirSync, existsSync, unlink } = require('fs');
 const del = require('del');
-const createBuild = require('./create_build');
+const createBuild = require('../create_build');
 
 const PLUGIN_FIXTURE = resolve(__dirname, '__fixtures__/create_build_test_plugin');
-const PLUGIN = require('../../lib/plugin_config')(PLUGIN_FIXTURE);
+const PLUGIN = require('../../../lib/plugin_config')(PLUGIN_FIXTURE);
 const PLUGIN_BUILD_DIR = resolve(PLUGIN_FIXTURE, 'build');
 const PLUGIN_BUILD_TARGET = resolve(PLUGIN_BUILD_DIR, 'kibana', PLUGIN.id);
 

packages/kbn-plugin-helpers/tasks/build/integration_tests/create_package.test.js

@@ -20,11 +20,11 @@
 const { resolve } = require('path');
 const { statSync } = require('fs');
 const del = require('del');
-const createBuild = require('./create_build');
-const createPackage = require('./create_package');
+const createBuild = require('../create_build');
+const createPackage = require('../create_package');
 
 const PLUGIN_FIXTURE = resolve(__dirname, '__fixtures__/create_package_test_plugin');
-const PLUGIN = require('../../lib/plugin_config')(PLUGIN_FIXTURE);
+const PLUGIN = require('../../../lib/plugin_config')(PLUGIN_FIXTURE);
 const PLUGIN_BUILD_DIR = resolve(PLUGIN_FIXTURE, 'build-custom');
 
 const buildVersion = PLUGIN.version;