Change telemetry optIn to default to true (#50490)

* Change optIn to default to true

* Update snapshot

* Fix eslint errors
This commit is contained in:
Mike Côté 2019-11-13 17:10:36 -05:00 committed by GitHub
parent 9212eb2d5f
commit bff235bf77
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 5 additions and 7 deletions

View file

@ -50,10 +50,8 @@ const telemetry = (kibana: any) => {
allowChangingOptInStatus: Joi.boolean().default(true),
optIn: Joi.when('allowChangingOptInStatus', {
is: false,
then: Joi.valid(true).required(),
otherwise: Joi.boolean()
.allow(null)
.default(null),
then: Joi.valid(true).default(true),
otherwise: Joi.boolean().default(true),
}),
// `config` is used internally and not intended to be set

View file

@ -35,7 +35,7 @@ exports[`TelemetryForm renders as expected when allows to change optIn status 1`
setting={
Object {
"ariaName": "Provide usage statistics",
"defVal": false,
"defVal": true,
"description": <React.Fragment>
<p>
Help us improve the Elastic Stack by providing usage statistics for basic features. We will not share this data outside of Elastic.

View file

@ -117,7 +117,7 @@ export class TelemetryForm extends Component {
type: 'boolean',
value: telemetryOptInProvider.getOptIn() || false,
description: this.renderDescription(),
defVal: false,
defVal: true,
ariaName: i18n.translate('telemetry.provideUsageStatisticsLabel', { defaultMessage: 'Provide usage statistics' })
}}
save={this.toggleOptIn}

View file

@ -44,7 +44,7 @@ export const getTelemetryOptIn: GetTelemetryOptIn = ({
}
if (telemetrySavedObject === null || typeof telemetrySavedObject.enabled !== 'boolean') {
return null;
return configTelemetryOptIn;
}
const savedOptIn = telemetrySavedObject.enabled;