maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Change telemetry optIn to default to true (#50490)

Browse source 
* Change optIn to default to true

* Update snapshot

* Fix eslint errors
This commit is contained in:
Mike Côté 2019-11-13 17:10:36 -05:00 committed by GitHub
parent 9212eb2d5f
commit bff235bf77
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/legacy/core_plugins/telemetry/index.ts
View file

@ -50,10 +50,8 @@ const telemetry = (kibana: any) => {
allowChangingOptInStatus: Joi.boolean().default(true), allowChangingOptInStatus: Joi.boolean().default(true),
optIn: Joi.when('allowChangingOptInStatus', { optIn: Joi.when('allowChangingOptInStatus', {
is: false, is: false,
then: Joi.valid(true).required(), then: Joi.valid(true).default(true),
otherwise: Joi.boolean() otherwise: Joi.boolean().default(true),
.allow(null)
.default(null),
}), }),
// `config` is used internally and not intended to be set // `config` is used internally and not intended to be set

2
src/legacy/core_plugins/telemetry/public/components/__snapshots__/telemetry_form.test.js.snap generated
View file

@ -35,7 +35,7 @@ exports[`TelemetryForm renders as expected when allows to change optIn status 1`
setting={ setting={
Object { Object {
"ariaName": "Provide usage statistics", "ariaName": "Provide usage statistics",
"defVal": false, "defVal": true,
"description": <React.Fragment> "description": <React.Fragment>
<p> <p>
Help us improve the Elastic Stack by providing usage statistics for basic features. We will not share this data outside of Elastic. Help us improve the Elastic Stack by providing usage statistics for basic features. We will not share this data outside of Elastic.

2
src/legacy/core_plugins/telemetry/public/components/telemetry_form.js
View file

@ -117,7 +117,7 @@ export class TelemetryForm extends Component {
type: 'boolean', type: 'boolean',
value: telemetryOptInProvider.getOptIn() || false, value: telemetryOptInProvider.getOptIn() || false,
description: this.renderDescription(), description: this.renderDescription(),
defVal: false, defVal: true,
ariaName: i18n.translate('telemetry.provideUsageStatisticsLabel', { defaultMessage: 'Provide usage statistics' }) ariaName: i18n.translate('telemetry.provideUsageStatisticsLabel', { defaultMessage: 'Provide usage statistics' })
}} }}
save={this.toggleOptIn} save={this.toggleOptIn}

2
src/legacy/core_plugins/telemetry/server/telemetry_config/get_telemetry_opt_in.ts
View file

@ -44,7 +44,7 @@ export const getTelemetryOptIn: GetTelemetryOptIn = ({
} }
if (telemetrySavedObject === null || typeof telemetrySavedObject.enabled !== 'boolean') { if (telemetrySavedObject === null || typeof telemetrySavedObject.enabled !== 'boolean') {
return null; return configTelemetryOptIn;
} }
const savedOptIn = telemetrySavedObject.enabled; const savedOptIn = telemetrySavedObject.enabled;