From c252732f025beccf5c24a878263908fb25f5b4c1 Mon Sep 17 00:00:00 2001
From: Tim Roes <mail@timroes.de>
Date: Mon, 20 May 2019 09:08:05 -0400
Subject: [PATCH] Improve links (#36639)

---
 docs/management/advanced-options.asciidoc                 | 2 +-
 .../edit_index_pattern/edit_index_pattern.html            | 2 +-
 src/legacy/core_plugins/kibana/ui_setting_defaults.js     | 2 +-
 .../markdown_vis/public/markdown_vis_params.html          | 2 +-
 .../metrics/public/components/markdown_editor.js          | 2 +-
 .../field_editor/__snapshots__/field_editor.test.js.snap  | 2 +-
 .../editors/bytes/__snapshots__/bytes.test.js.snap        | 2 +-
 .../editors/date/__snapshots__/date.test.js.snap          | 4 ++--
 .../components/field_format_editor/editors/date/date.js   | 2 +-
 .../editors/number/__snapshots__/number.test.js.snap      | 2 +-
 .../field_format_editor/editors/number/number.js          | 2 +-
 .../editors/percent/__snapshots__/percent.test.js.snap    | 2 +-
 .../__snapshots__/warning_call_out.test.js.snap           | 4 ++--
 .../components/scripting_call_outs/warning_call_out.js    | 4 ++--
 .../components/scripting_help/scripting_syntax.js         | 8 ++++----
 src/legacy/ui/public/field_editor/field_editor.js         | 2 +-
 .../public/filter_bar/filter_editor/range_value_input.tsx | 2 +-
 x-pack/plugins/watcher/README.md                          | 2 +-
 18 files changed, 24 insertions(+), 24 deletions(-)

diff --git a/docs/management/advanced-options.asciidoc b/docs/management/advanced-options.asciidoc
index 5da9b9ad6c2e..ccf1d3428f17 100644
--- a/docs/management/advanced-options.asciidoc
+++ b/docs/management/advanced-options.asciidoc
@@ -26,7 +26,7 @@ removes it from {kib} permanently.
 [horizontal]
 `csv:quoteValues`:: Set this property to `true` to quote exported values.
 `csv:separator`:: A string that serves as the separator for exported values.
-`dateFormat`:: The format to use for displaying http://momentjs.com/docs/#/displaying/format/[pretty formatted dates].
+`dateFormat`:: The format to use for displaying https://momentjs.com/docs/#/displaying/format/[pretty formatted dates].
 `dateFormat:dow`:: The day that a week should start on.
 `dateFormat:scaled`:: The values that define the format to use to render ordered time-based data. Formatted timestamps must
 adapt to the interval between measurements. Keys are http://en.wikipedia.org/wiki/ISO_8601#Time_intervals[ISO8601 intervals].
diff --git a/src/legacy/core_plugins/kibana/public/management/sections/index_patterns/edit_index_pattern/edit_index_pattern.html b/src/legacy/core_plugins/kibana/public/management/sections/index_patterns/edit_index_pattern/edit_index_pattern.html
index ff132d5bdeb0..6a0be663f939 100644
--- a/src/legacy/core_plugins/kibana/public/management/sections/index_patterns/edit_index_pattern/edit_index_pattern.html
+++ b/src/legacy/core_plugins/kibana/public/management/sections/index_patterns/edit_index_pattern/edit_index_pattern.html
@@ -48,7 +48,7 @@
           <span i18n-id="kbn.management.editIndexPattern.timeFilterLabel.timeFilterDetail"
             i18n-default-message="This page lists every field in the {indexPatternTitle} index and the field's associated core type as recorded by Elasticsearch. To change a field type, use the Elasticsearch"
             i18n-values="{ html_indexPatternTitle: '<strong>' + indexPattern.title + '</strong>' }"></span>
-          <a target="_window" class="euiLink euiLink--primary" href="http://www.elastic.co/guide/en/elasticsearch/reference/current/mapping.html">
+          <a target="_blank" class="euiLink euiLink--primary" href="http://www.elastic.co/guide/en/elasticsearch/reference/current/mapping.html">
             <span i18n-id="kbn.management.editIndexPattern.timeFilterLabel.mappingAPILink"
                   i18n-default-message="Mapping API"></span>
             <i aria-hidden="true" class="fa-link fa"></i>
diff --git a/src/legacy/core_plugins/kibana/ui_setting_defaults.js b/src/legacy/core_plugins/kibana/ui_setting_defaults.js
index e23d183a1c0f..bb7ccd57f251 100644
--- a/src/legacy/core_plugins/kibana/ui_setting_defaults.js
+++ b/src/legacy/core_plugins/kibana/ui_setting_defaults.js
@@ -141,7 +141,7 @@ export function getUiSettingDefaults() {
                      'kbn.advancedSettings.dateFormat.optionsLinkText',
         values: {
           formatLink:
-            '<a href="http://momentjs.com/docs/#/displaying/format/" target="_blank" rel="noopener noreferrer">' +
+            '<a href="https://momentjs.com/docs/#/displaying/format/" target="_blank" rel="noopener noreferrer">' +
             i18n.translate('kbn.advancedSettings.dateFormat.optionsLinkText', {
               defaultMessage: 'format',
             }) +
diff --git a/src/legacy/core_plugins/markdown_vis/public/markdown_vis_params.html b/src/legacy/core_plugins/markdown_vis/public/markdown_vis_params.html
index b369eff62bf5..d8d2a77651af 100644
--- a/src/legacy/core_plugins/markdown_vis/public/markdown_vis_params.html
+++ b/src/legacy/core_plugins/markdown_vis/public/markdown_vis_params.html
@@ -3,7 +3,7 @@
     <div class="clearfix form-group">
       <label for="markdownVisInput">Markdown</label>
       <small class="pull-right">
-        <a target="_window" href="https://help.github.com/articles/github-flavored-markdown/">
+        <a target="_blank" href="https://help.github.com/articles/github-flavored-markdown/" rel="noreferrer noopener">
           <icon aria-hidden="true" size="'s'" type="'link'"></icon>
           <span
             i18n-id="markdownVis.params.helpLinkLabel"
diff --git a/src/legacy/core_plugins/metrics/public/components/markdown_editor.js b/src/legacy/core_plugins/metrics/public/components/markdown_editor.js
index 23545922aa17..b96db46aa391 100644
--- a/src/legacy/core_plugins/metrics/public/components/markdown_editor.js
+++ b/src/legacy/core_plugins/metrics/public/components/markdown_editor.js
@@ -158,7 +158,7 @@ class MarkdownEditor extends Component {
                 {handlebarLink} on the available expressions."
                 values={{
                   handlebarLink: (
-                    <a href="http://handlebarsjs.com/expressions.html" target="_BLANK">
+                    <a href="http://handlebarsjs.com/expressions.html" target="_BLANK" rel="noreferrer noopener">
                       <FormattedMessage
                         id="tsvb.markdownEditor.howUseVariablesInMarkdownDescription.documentationLinkText"
                         defaultMessage="Click here for documentation"
diff --git a/src/legacy/ui/public/field_editor/__snapshots__/field_editor.test.js.snap b/src/legacy/ui/public/field_editor/__snapshots__/field_editor.test.js.snap
index 41560f8971ae..71d464d42330 100644
--- a/src/legacy/ui/public/field_editor/__snapshots__/field_editor.test.js.snap
+++ b/src/legacy/ui/public/field_editor/__snapshots__/field_editor.test.js.snap
@@ -843,7 +843,7 @@ exports[`FieldEditor should show deprecated lang warning 1`] = `
                 </eui-code>,
                 "painlessLink": <eui-link
                   href="(docLink for scriptedFields.painless)"
-                  target="_window"
+                  target="_blank"
                 >
                   <FormattedMessage
                     defaultMessage="Painless"
diff --git a/src/legacy/ui/public/field_editor/components/field_format_editor/editors/bytes/__snapshots__/bytes.test.js.snap b/src/legacy/ui/public/field_editor/components/field_format_editor/editors/bytes/__snapshots__/bytes.test.js.snap
index 7af2a164bd8c..d786876a501d 100644
--- a/src/legacy/ui/public/field_editor/components/field_format_editor/editors/bytes/__snapshots__/bytes.test.js.snap
+++ b/src/legacy/ui/public/field_editor/components/field_format_editor/editors/bytes/__snapshots__/bytes.test.js.snap
@@ -12,7 +12,7 @@ exports[`BytesFormatEditor should render normally 1`] = `
         <EuiLink
           color="primary"
           href="https://adamwdraper.github.io/Numeral-js/"
-          target="_window"
+          target="_blank"
           type="button"
         >
           <FormattedMessage
diff --git a/src/legacy/ui/public/field_editor/components/field_format_editor/editors/date/__snapshots__/date.test.js.snap b/src/legacy/ui/public/field_editor/components/field_format_editor/editors/date/__snapshots__/date.test.js.snap
index 42df3b761d96..69473f06514c 100644
--- a/src/legacy/ui/public/field_editor/components/field_format_editor/editors/date/__snapshots__/date.test.js.snap
+++ b/src/legacy/ui/public/field_editor/components/field_format_editor/editors/date/__snapshots__/date.test.js.snap
@@ -11,8 +11,8 @@ exports[`DateFormatEditor should render normally 1`] = `
       <span>
         <EuiLink
           color="primary"
-          href="http://momentjs.com/"
-          target="_window"
+          href="https://momentjs.com/"
+          target="_blank"
           type="button"
         >
           <FormattedMessage
diff --git a/src/legacy/ui/public/field_editor/components/field_format_editor/editors/date/date.js b/src/legacy/ui/public/field_editor/components/field_format_editor/editors/date/date.js
index 476e06ef44db..de672fa9ff97 100644
--- a/src/legacy/ui/public/field_editor/components/field_format_editor/editors/date/date.js
+++ b/src/legacy/ui/public/field_editor/components/field_format_editor/editors/date/date.js
@@ -71,7 +71,7 @@ export class DateFormatEditor extends DefaultFormatEditor {
           error={error}
           helpText={
             <span>
-              <EuiLink target="_window" href="http://momentjs.com/">
+              <EuiLink target="_blank" href="https://momentjs.com/">
                 <FormattedMessage id="common.ui.fieldEditor.date.documentationLabel" defaultMessage="Documentation" />&nbsp;
                 <EuiIcon type="link" />
               </EuiLink>
diff --git a/src/legacy/ui/public/field_editor/components/field_format_editor/editors/number/__snapshots__/number.test.js.snap b/src/legacy/ui/public/field_editor/components/field_format_editor/editors/number/__snapshots__/number.test.js.snap
index bf47fd73b838..50550e556b0f 100644
--- a/src/legacy/ui/public/field_editor/components/field_format_editor/editors/number/__snapshots__/number.test.js.snap
+++ b/src/legacy/ui/public/field_editor/components/field_format_editor/editors/number/__snapshots__/number.test.js.snap
@@ -12,7 +12,7 @@ exports[`NumberFormatEditor should render normally 1`] = `
         <EuiLink
           color="primary"
           href="https://adamwdraper.github.io/Numeral-js/"
-          target="_window"
+          target="_blank"
           type="button"
         >
           <FormattedMessage
diff --git a/src/legacy/ui/public/field_editor/components/field_format_editor/editors/number/number.js b/src/legacy/ui/public/field_editor/components/field_format_editor/editors/number/number.js
index a07c6b4382f7..0783f0f17134 100644
--- a/src/legacy/ui/public/field_editor/components/field_format_editor/editors/number/number.js
+++ b/src/legacy/ui/public/field_editor/components/field_format_editor/editors/number/number.js
@@ -62,7 +62,7 @@ export class NumberFormatEditor extends DefaultFormatEditor {
           }
           helpText={
             <span>
-              <EuiLink target="_window" href="https://adamwdraper.github.io/Numeral-js/">
+              <EuiLink target="_blank" href="https://adamwdraper.github.io/Numeral-js/">
                 <FormattedMessage id="common.ui.fieldEditor.number.documentationLabel" defaultMessage="Documentation" />&nbsp;
                 <EuiIcon type="link" />
               </EuiLink>
diff --git a/src/legacy/ui/public/field_editor/components/field_format_editor/editors/percent/__snapshots__/percent.test.js.snap b/src/legacy/ui/public/field_editor/components/field_format_editor/editors/percent/__snapshots__/percent.test.js.snap
index 4fb01d8b1ab2..4c3043a09389 100644
--- a/src/legacy/ui/public/field_editor/components/field_format_editor/editors/percent/__snapshots__/percent.test.js.snap
+++ b/src/legacy/ui/public/field_editor/components/field_format_editor/editors/percent/__snapshots__/percent.test.js.snap
@@ -12,7 +12,7 @@ exports[`PercentFormatEditor should render normally 1`] = `
         <EuiLink
           color="primary"
           href="https://adamwdraper.github.io/Numeral-js/"
-          target="_window"
+          target="_blank"
           type="button"
         >
           <FormattedMessage
diff --git a/src/legacy/ui/public/field_editor/components/scripting_call_outs/__snapshots__/warning_call_out.test.js.snap b/src/legacy/ui/public/field_editor/components/scripting_call_outs/__snapshots__/warning_call_out.test.js.snap
index 47c419d44f8c..837476dba054 100644
--- a/src/legacy/ui/public/field_editor/components/scripting_call_outs/__snapshots__/warning_call_out.test.js.snap
+++ b/src/legacy/ui/public/field_editor/components/scripting_call_outs/__snapshots__/warning_call_out.test.js.snap
@@ -23,7 +23,7 @@ exports[`ScriptingWarningCallOut should render normally 1`] = `
             "scripFields": <EuiLink
               color="primary"
               href="(docLink for scriptedFields.scriptFields)"
-              target="_window"
+              target="_blank"
               type="button"
             >
               <FormattedMessage
@@ -39,7 +39,7 @@ exports[`ScriptingWarningCallOut should render normally 1`] = `
             "scriptsInAggregation": <EuiLink
               color="primary"
               href="(docLink for scriptedFields.scriptAggs)"
-              target="_window"
+              target="_blank"
               type="button"
             >
               <FormattedMessage
diff --git a/src/legacy/ui/public/field_editor/components/scripting_call_outs/warning_call_out.js b/src/legacy/ui/public/field_editor/components/scripting_call_outs/warning_call_out.js
index 98a101a8de82..84f11751132d 100644
--- a/src/legacy/ui/public/field_editor/components/scripting_call_outs/warning_call_out.js
+++ b/src/legacy/ui/public/field_editor/components/scripting_call_outs/warning_call_out.js
@@ -45,13 +45,13 @@ export const ScriptingWarningCallOut = ({
             defaultMessage="Please familiarize yourself with {scripFields} and with {scriptsInAggregation} before using scripted fields."
             values={{
               scripFields: (
-                <EuiLink target="_window" href={getDocLink('scriptedFields.scriptFields')}>
+                <EuiLink target="_blank" href={getDocLink('scriptedFields.scriptFields')}>
                   <FormattedMessage id="common.ui.fieldEditor.warningCallOutLabel.scripFieldsLink" defaultMessage="script fields" />&nbsp;
                   <EuiIcon type="link" />
                 </EuiLink>
               ),
               scriptsInAggregation: (
-                <EuiLink target="_window" href={getDocLink('scriptedFields.scriptAggs')}>
+                <EuiLink target="_blank" href={getDocLink('scriptedFields.scriptAggs')}>
                   <FormattedMessage
                     id="common.ui.fieldEditor.warningCallOutLabel.scriptsInAggregationLink"
                     defaultMessage="scripts in aggregations"
diff --git a/src/legacy/ui/public/field_editor/components/scripting_help/scripting_syntax.js b/src/legacy/ui/public/field_editor/components/scripting_help/scripting_syntax.js
index 41b58689c0a8..d8695d4888e5 100644
--- a/src/legacy/ui/public/field_editor/components/scripting_help/scripting_syntax.js
+++ b/src/legacy/ui/public/field_editor/components/scripting_help/scripting_syntax.js
@@ -45,7 +45,7 @@ export const ScriptingSyntax = () => (
           values={{
             painless: (
               <EuiLink
-                target="_window"
+                target="_blank"
                 href={getDocLink('scriptedFields.painless')}
               >
                 <FormattedMessage id="common.ui.fieldEditor.syntax.defaultLabel.painlessLink" defaultMessage="Painless" />
@@ -68,7 +68,7 @@ export const ScriptingSyntax = () => (
           values={{
             javaAPIs: (
               <EuiLink
-                target="_window"
+                target="_blank"
                 href={getDocLink('scriptedFields.painlessApi')}
               >
                 <FormattedMessage id="common.ui.fieldEditor.syntax.painlessLabel.javaAPIsLink" defaultMessage="native Java APIs" />&nbsp;
@@ -77,7 +77,7 @@ export const ScriptingSyntax = () => (
             ),
             syntax: (
               <EuiLink
-                target="_window"
+                target="_blank"
                 href={getDocLink('scriptedFields.painlessSyntax')}
               >
                 <FormattedMessage id="common.ui.fieldEditor.syntax.painlessLabel.syntaxLink" defaultMessage="syntax" />&nbsp;
@@ -102,7 +102,7 @@ export const ScriptingSyntax = () => (
           values={{
             lucene: (
               <EuiLink
-                target="_window"
+                target="_blank"
                 href={getDocLink('scriptedFields.luceneExpressions')}
               >
                 <FormattedMessage id="common.ui.fieldEditor.syntax.lucene.commonLabel.luceneLink" defaultMessage="Lucene Expressions" />
diff --git a/src/legacy/ui/public/field_editor/field_editor.js b/src/legacy/ui/public/field_editor/field_editor.js
index f8552d32907e..93a1cee6a7ef 100644
--- a/src/legacy/ui/public/field_editor/field_editor.js
+++ b/src/legacy/ui/public/field_editor/field_editor.js
@@ -295,7 +295,7 @@ export class FieldEditorComponent extends PureComponent {
               values={{
                 language: <EuiCode>{field.lang}</EuiCode>,
                 painlessLink: (
-                  <EuiLink target="_window" href={getDocLink('scriptedFields.painless')}>
+                  <EuiLink target="_blank" href={getDocLink('scriptedFields.painless')}>
                     <FormattedMessage
                       id="common.ui.fieldEditor.warningLabel.painlessLinkLabel"
                       defaultMessage="Painless"
diff --git a/src/legacy/ui/public/filter_bar/filter_editor/range_value_input.tsx b/src/legacy/ui/public/filter_bar/filter_editor/range_value_input.tsx
index 7343c5722f22..cf3cbf5dc030 100644
--- a/src/legacy/ui/public/filter_bar/filter_editor/range_value_input.tsx
+++ b/src/legacy/ui/public/filter_bar/filter_editor/range_value_input.tsx
@@ -89,7 +89,7 @@ class RangeValueInputUI extends Component<Props> {
           </EuiFlexItem>
         </EuiFlexGroup>
         {type === 'date' ? (
-          <EuiLink target="_window" href={getDocLink('date.dateMath')}>
+          <EuiLink target="_blank" href={getDocLink('date.dateMath')}>
             <FormattedMessage
               id="common.ui.filterEditor.dateFormatHelpLinkLabel"
               defaultMessage="Accepted date formats"
diff --git a/x-pack/plugins/watcher/README.md b/x-pack/plugins/watcher/README.md
index cce98bfce73a..bc19f4e4fd96 100644
--- a/x-pack/plugins/watcher/README.md
+++ b/x-pack/plugins/watcher/README.md
@@ -159,7 +159,7 @@ data (as that is typically done by the server models already).
 
 They do, however, serve as a consistent place in the data path for translating wire representations of certain types of data into
 more suitable in-memory representations, for example: converting an [ISO8601-formatted timestamp](https://en.wikipedia.org/wiki/ISO_8601)
-into a [moment instance](http://momentjs.com/).
+into a [moment instance](https://momentjs.com/).
 
 They are also the right place for establishing relationships between models — for example, a watch contains many actions — and for
 encapsulating operations around such relationships — for example, updating the status of a watch's action.