From c29a17ce3cb3d51087380e0fe8ee6d5c0d95c3a6 Mon Sep 17 00:00:00 2001
From: Spencer <email@spalger.com>
Date: Mon, 12 Aug 2019 10:50:22 -0700
Subject: [PATCH] [ftr] enable visualRegression jobs (#42989)

* enable visualRegression jobs

* skip the console and login visual tests
---
 .ci/jobs.yml                                      | 4 ++--
 test/visual_regression/tests/console_app.ts       | 2 +-
 x-pack/test/visual_regression/tests/login_page.js | 3 ++-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/.ci/jobs.yml b/.ci/jobs.yml
index fc3e80064fa6..89fce3cf488d 100644
--- a/.ci/jobs.yml
+++ b/.ci/jobs.yml
@@ -14,7 +14,7 @@ JOB:
   - kibana-ciGroup10
   - kibana-ciGroup11
   - kibana-ciGroup12
-  # - kibana-visualRegression
+  - kibana-visualRegression
 
   # make sure all x-pack-ciGroups are listed in test/scripts/jenkins_xpack_ci_group.sh
   - x-pack-firefoxSmoke
@@ -28,7 +28,7 @@ JOB:
   - x-pack-ciGroup8
   - x-pack-ciGroup9
   - x-pack-ciGroup10
-  # - x-pack-visualRegression
+  - x-pack-visualRegression
 
 # `~` is yaml for `null`
 exclude: ~
diff --git a/test/visual_regression/tests/console_app.ts b/test/visual_regression/tests/console_app.ts
index 9d745942a81f..555664f31e82 100644
--- a/test/visual_regression/tests/console_app.ts
+++ b/test/visual_regression/tests/console_app.ts
@@ -37,7 +37,7 @@ export default function({ getService, getPageObjects }: FtrProviderContext) {
   const visualTesting = getService('visualTesting');
   const PageObjects = getPageObjects(['common', 'console']);
 
-  describe('console app', function describeIndexTests() {
+  describe.skip('console app', function describeIndexTests() {
     before(async () => {
       log.debug('navigateTo console');
       await PageObjects.common.navigateToApp('console');
diff --git a/x-pack/test/visual_regression/tests/login_page.js b/x-pack/test/visual_regression/tests/login_page.js
index 046e0cd83d7c..cfc53735dffc 100644
--- a/x-pack/test/visual_regression/tests/login_page.js
+++ b/x-pack/test/visual_regression/tests/login_page.js
@@ -12,7 +12,7 @@ export default function ({ getService, getPageObjects }) {
   const PageObjects = getPageObjects(['common', 'security']);
 
   describe('Security', () => {
-    describe('Login Page', () => {
+    describe.skip('Login Page', () => {
       before(async () => {
         await esArchiver.load('empty_kibana');
         await PageObjects.security.logout();
@@ -28,6 +28,7 @@ export default function ({ getService, getPageObjects }) {
 
       it('renders login page', async () => {
         await PageObjects.common.navigateToApp('login');
+
         await retry.waitFor('login page visible', async () => (
           await testSubjects.exists('loginSubmit')
         ));