maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Remove plugin circular deps between actions -> case and case -> securitySolution (#88106)

Browse source
This commit is contained in:
Robert Austin 2021-01-21 08:47:15 -05:00 committed by GitHub
parent f0be0ade19
commit c3a69fe28b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/dev/run_find_plugins_with_circular_deps.ts
View file

@ -20,8 +20,6 @@ interface Options {
type CircularDepList = Set<string>;
const allowedList: CircularDepList = new Set([
'x-pack/plugins/actions -> x-pack/plugins/case',
'x-pack/plugins/case -> x-pack/plugins/security_solution',
'x-pack/plugins/apm -> x-pack/plugins/infra',
'x-pack/plugins/lists -> x-pack/plugins/security_solution',
'x-pack/plugins/security -> x-pack/plugins/spaces',

2
x-pack/plugins/actions/server/lib/ensure_sufficient_license.ts
View file

@ -8,7 +8,7 @@ import { LICENSE_TYPE } from '../../../licensing/common/types';
import { ServerLogActionTypeId, IndexActionTypeId } from '../builtin_action_types';
import { ActionTypeConfig, ActionTypeSecrets, ActionTypeParams } from '../types';
export const CASE_ACTION_TYPE_ID = '.case';
const CASE_ACTION_TYPE_ID = '.case';
const ACTIONS_SCOPED_WITHIN_STACK = new Set([
ServerLogActionTypeId,

8
x-pack/plugins/case/common/api/connectors/mappings.ts
View file

@ -7,7 +7,6 @@
/* eslint-disable @kbn/eslint/no-restricted-paths */
import * as rt from 'io-ts';
import { ElasticUser } from '../../../../security_solution/public/cases/containers/types';
import {
PushToServiceApiParams as JiraPushToServiceApiParams,
Incident as JiraIncident,
@ -24,6 +23,13 @@ import { ResilientFieldsRT } from './resilient';
import { ServiceNowFieldsRT } from './servicenow';
import { JiraFieldsRT } from './jira';
// Formerly imported from security_solution
export interface ElasticUser {
readonly email?: string | null;
readonly fullName?: string | null;
readonly username?: string | null;
}
export {
JiraPushToServiceApiParams,
ResilientPushToServiceApiParams,

3
x-pack/plugins/case/server/connectors/case/index.ts
View file

@ -23,7 +23,6 @@ import { GetActionTypeParams } from '..';
const supportedSubActions: string[] = ['create', 'update', 'addComment'];
export const CASE_ACTION_TYPE_ID = '.case';
// action type definition
export function getActionType({
logger,
@ -34,7 +33,7 @@ export function getActionType({
alertsService,
}: GetActionTypeParams): CaseActionType {
return {
id: CASE_ACTION_TYPE_ID,
id: '.case',
minimumLicenseRequired: 'basic',
name: i18n.NAME,
validate: {

1
x-pack/plugins/case/server/connectors/index.ts
View file

@ -21,7 +21,6 @@ import {
} from '../services';
import { getActionType as getCaseConnector } from './case';
export { CASE_ACTION_TYPE_ID } from './case';
export interface GetActionTypeParams {
logger: Logger;

1
x-pack/plugins/case/server/index.ts
View file

@ -8,7 +8,6 @@ import { PluginInitializerContext } from 'kibana/server';
import { ConfigSchema } from './config';
import { CasePlugin } from './plugin';
export { CASE_ACTION_TYPE_ID } from './connectors';
export { CaseRequestContext } from './types';
export const config = { schema: ConfigSchema };
export const plugin = (initializerContext: PluginInitializerContext) =>