From 6291cdcf242d0607d2837ca06f35a956fabdc9e2 Mon Sep 17 00:00:00 2001
From: Khalah Jones-Golden <khasan222@gmail.com>
Date: Wed, 21 Oct 2015 16:56:59 -0400
Subject: [PATCH 1/3] [Embed] Moved the chrome.getVisible up one level for
 sidebar in visualize closes #5165. Added a chrome.getVisible to spy panel
 closes #3820

---
 src/plugins/kibana/public/visualize/editor/editor.html | 4 ++--
 src/ui/public/visualize/visualize.html                 | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/plugins/kibana/public/visualize/editor/editor.html b/src/plugins/kibana/public/visualize/editor/editor.html
index 1f9bd00591ae..69a8ea8cb3f2 100644
--- a/src/plugins/kibana/public/visualize/editor/editor.html
+++ b/src/plugins/kibana/public/visualize/editor/editor.html
@@ -126,8 +126,8 @@
 
   <div class="vis-editor-content">
 
-    <div class="collapsible-sidebar">
-        <vis-editor-sidebar class="vis-editor-sidebar" ng-if="chrome.getVisible()"></vis-editor-sidebar>
+    <div class="collapsible-sidebar" ng-if="chrome.getVisible()">
+        <vis-editor-sidebar class="vis-editor-sidebar"></vis-editor-sidebar>
     </div>
 
     <div class="vis-editor-canvas" ng-class="{ embedded: !chrome.getVisible() }">
diff --git a/src/ui/public/visualize/visualize.html b/src/ui/public/visualize/visualize.html
index 4b04f4b739a8..12a25f342a57 100644
--- a/src/ui/public/visualize/visualize.html
+++ b/src/ui/public/visualize/visualize.html
@@ -11,4 +11,4 @@
   ng-class="{ loading: vis.type.requiresSearch && searchSource.activeFetchCount > 0 }"
   class="visualize-chart"></div>
 <!-- <pre>{{chartData | json}}</pre> -->
-<visualize-spy ng-if="vis.type.requiresSearch"></visualize-spy>
\ No newline at end of file
+<visualize-spy ng-if="vis.type.requiresSearch && chrome.getVisible()"></visualize-spy>

From 3438cd22970431357359bf9661b491cc8dd0df05 Mon Sep 17 00:00:00 2001
From: Khalah Jones-Golden <khasan222@gmail.com>
Date: Tue, 27 Oct 2015 14:38:12 -0400
Subject: [PATCH 2/3] [Visualize] Changed the vizualize directive to also
 accept the chrome module

---
 src/plugins/kibana/public/dashboard/components/panel/panel.html | 1 +
 src/plugins/kibana/public/discover/index.html                   | 2 +-
 src/plugins/kibana/public/visualize/editor/editor.html          | 2 +-
 src/ui/public/visualize/visualize.js                            | 1 +
 4 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/plugins/kibana/public/dashboard/components/panel/panel.html b/src/plugins/kibana/public/dashboard/components/panel/panel.html
index 586324b42160..692e0171a937 100644
--- a/src/plugins/kibana/public/dashboard/components/panel/panel.html
+++ b/src/plugins/kibana/public/dashboard/components/panel/panel.html
@@ -28,6 +28,7 @@
   <visualize ng-switch-when="visualization"
     vis="savedObj.vis"
     search-source="savedObj.searchSource"
+    chrome="chrome"
     class="panel-content">
   </visualize>
 
diff --git a/src/plugins/kibana/public/discover/index.html b/src/plugins/kibana/public/discover/index.html
index ae64f37439ae..96c69dd67829 100644
--- a/src/plugins/kibana/public/discover/index.html
+++ b/src/plugins/kibana/public/discover/index.html
@@ -176,7 +176,7 @@
 
               </header>
 
-              <visualize ng-if="vis && rows.length != 0" vis="vis" es-resp="mergedEsResp" search-source="searchSource"></visualize>
+              <visualize ng-if="vis && rows.length != 0" chrome="chrome" vis="vis" es-resp="mergedEsResp" search-source="searchSource"></visualize>
             </div>
 
             <div class="discover-table" fixed-scroll>
diff --git a/src/plugins/kibana/public/visualize/editor/editor.html b/src/plugins/kibana/public/visualize/editor/editor.html
index 69a8ea8cb3f2..8eee6e6a186c 100644
--- a/src/plugins/kibana/public/visualize/editor/editor.html
+++ b/src/plugins/kibana/public/visualize/editor/editor.html
@@ -138,7 +138,7 @@
         </div>
       </div>
 
-      <visualize vis="vis" editable-vis="editableVis"  search-source="savedVis.searchSource"></visualize>
+      <visualize chrome="chrome" vis="vis" editable-vis="editableVis"  search-source="savedVis.searchSource"></visualize>
     </div>
   </div>
 
diff --git a/src/ui/public/visualize/visualize.js b/src/ui/public/visualize/visualize.js
index af36b581a891..1b7dbe77fb5d 100644
--- a/src/ui/public/visualize/visualize.js
+++ b/src/ui/public/visualize/visualize.js
@@ -16,6 +16,7 @@ define(function (require) {
     return {
       restrict: 'E',
       scope : {
+        chrome: '=',
         vis: '=',
         editableVis: '=?',
         esResp: '=?',

From eba2c44070ae5f0d97cff8384782ccd6e988e51b Mon Sep 17 00:00:00 2001
From: Khalah Jones-Golden <khasan222@gmail.com>
Date: Fri, 30 Oct 2015 14:51:20 -0400
Subject: [PATCH 3/3] [SpyPanel] reduced scope of new parameter on visualize,
 added a default if no option is passed in for show-spy-panel Removed
 conditional on  from discover

---
 .../kibana/public/dashboard/components/panel/panel.html     | 2 +-
 src/plugins/kibana/public/discover/index.html               | 2 +-
 src/plugins/kibana/public/visualize/editor/editor.html      | 2 +-
 src/ui/public/visualize/visualize.html                      | 2 +-
 src/ui/public/visualize/visualize.js                        | 6 +++++-
 5 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/src/plugins/kibana/public/dashboard/components/panel/panel.html b/src/plugins/kibana/public/dashboard/components/panel/panel.html
index 692e0171a937..b23b4aea78c0 100644
--- a/src/plugins/kibana/public/dashboard/components/panel/panel.html
+++ b/src/plugins/kibana/public/dashboard/components/panel/panel.html
@@ -28,7 +28,7 @@
   <visualize ng-switch-when="visualization"
     vis="savedObj.vis"
     search-source="savedObj.searchSource"
-    chrome="chrome"
+    show-spy-panel="chrome.getVisible()"
     class="panel-content">
   </visualize>
 
diff --git a/src/plugins/kibana/public/discover/index.html b/src/plugins/kibana/public/discover/index.html
index 96c69dd67829..ae64f37439ae 100644
--- a/src/plugins/kibana/public/discover/index.html
+++ b/src/plugins/kibana/public/discover/index.html
@@ -176,7 +176,7 @@
 
               </header>
 
-              <visualize ng-if="vis && rows.length != 0" chrome="chrome" vis="vis" es-resp="mergedEsResp" search-source="searchSource"></visualize>
+              <visualize ng-if="vis && rows.length != 0" vis="vis" es-resp="mergedEsResp" search-source="searchSource"></visualize>
             </div>
 
             <div class="discover-table" fixed-scroll>
diff --git a/src/plugins/kibana/public/visualize/editor/editor.html b/src/plugins/kibana/public/visualize/editor/editor.html
index 8eee6e6a186c..6b9d551b30a2 100644
--- a/src/plugins/kibana/public/visualize/editor/editor.html
+++ b/src/plugins/kibana/public/visualize/editor/editor.html
@@ -138,7 +138,7 @@
         </div>
       </div>
 
-      <visualize chrome="chrome" vis="vis" editable-vis="editableVis"  search-source="savedVis.searchSource"></visualize>
+      <visualize show-spy-panel="chrome.getVisible()" vis="vis" editable-vis="editableVis"  search-source="savedVis.searchSource"></visualize>
     </div>
   </div>
 
diff --git a/src/ui/public/visualize/visualize.html b/src/ui/public/visualize/visualize.html
index 12a25f342a57..15b504724499 100644
--- a/src/ui/public/visualize/visualize.html
+++ b/src/ui/public/visualize/visualize.html
@@ -11,4 +11,4 @@
   ng-class="{ loading: vis.type.requiresSearch && searchSource.activeFetchCount > 0 }"
   class="visualize-chart"></div>
 <!-- <pre>{{chartData | json}}</pre> -->
-<visualize-spy ng-if="vis.type.requiresSearch && chrome.getVisible()"></visualize-spy>
+<visualize-spy ng-if="vis.type.requiresSearch && showSpyPanel"></visualize-spy>
diff --git a/src/ui/public/visualize/visualize.js b/src/ui/public/visualize/visualize.js
index 1b7dbe77fb5d..9d8bec05af23 100644
--- a/src/ui/public/visualize/visualize.js
+++ b/src/ui/public/visualize/visualize.js
@@ -16,7 +16,7 @@ define(function (require) {
     return {
       restrict: 'E',
       scope : {
-        chrome: '=',
+        showSpyPanel: '=?',
         vis: '=',
         editableVis: '=?',
         esResp: '=?',
@@ -27,6 +27,10 @@ define(function (require) {
         var chart; // set in "vis" watcher
         var minVisChartHeight = 180;
 
+        if (_.isUndefined($scope.showSpyPanel)) {
+          $scope.showSpyPanel = true;
+        }
+
         function getter(selector) {
           return function () {
             var $sel = $el.find(selector);