maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Maps] do not call MapEmbeddable updateInput after embeddable is destroyed (#95337)

Browse source
This commit is contained in:
Nathan Reese 2021-03-24 14:02:31 -06:00 committed by GitHub
parent 983c3a0139
commit c7aba55f7b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
x-pack/plugins/maps/public/embeddable/map_embeddable.tsx
View file

@ -93,6 +93,7 @@ export class MapEmbeddable
implements ReferenceOrValueEmbeddable<MapByValueInput, MapByReferenceInput> {
type = MAP_SAVED_OBJECT_TYPE;
private _isActive: boolean;
private _savedMap: SavedMap;
private _renderTooltipContent?: RenderToolTipContent;
private _subscription: Subscription;
@ -118,6 +119,7 @@ export class MapEmbeddable
parent
);
this._isActive = true;
this._savedMap = new SavedMap({ mapEmbeddableInput: initialInput });
this._initializeSaveMap();
this._subscription = this.getUpdated$().subscribe(() => this.onUpdate());
@ -404,6 +406,7 @@ export class MapEmbeddable
destroy() {
super.destroy();
this._isActive = false;
if (this._unsubscribeFromStore) {
this._unsubscribeFromStore();
}
@ -424,6 +427,9 @@ export class MapEmbeddable
}
_handleStoreChanges() {
if (!this._isActive) {
return;
}
const center = getMapCenter(this._savedMap.getStore().getState());
const zoom = getMapZoom(this._savedMap.getStore().getState());