maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[ML] Fixes a race condition where the chart tooltip could be hidden even if it should be shown. (#23270)

Browse source 
- Even with the check if fadeTimeout was set in show(), I could reproduce race conditions where a new tooltip would disappear again, because a previous fadeTimeout would trigger and set the new tooltips display to none.
- This PR fixes it by adding a non-asynchronous visible flag to mlChartTooltipService to check if the tooltip should stay visible if fadeTimeout triggers.
This commit is contained in:
Walter Rafelsberger 2018-09-19 10:53:27 +02:00 committed by GitHub
parent cae4443c0b
commit c940c6d111
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
x-pack/plugins/ml/public/components/chart_tooltip/chart_tooltip_service.js
View file

@ -14,6 +14,7 @@ const FADE_TIMEOUT_MS = 200;
export const mlChartTooltipService = {
element: null,
fadeTimeout: null,
visible: false
};
mlChartTooltipService.show = function (contents, target, offset = { x: 0, y: 0 }) {
@ -21,6 +22,7 @@ mlChartTooltipService.show = function (contents, target, offset = { x: 0, y: 0 }
return;
}
this.visible = true;
// if a previous fade out was happening, stop it
if (this.fadeTimeout !== null) {
clearTimeout(this.fadeTimeout);
@ -64,6 +66,8 @@ mlChartTooltipService.hide = function () {
return;
}
this.visible = false;
this.element.css({
opacity: '0',
});
@ -71,7 +75,9 @@ mlChartTooltipService.hide = function () {
// after the fade out transition has finished, set the display to
// none so it doesn't block any mouse events underneath it.
this.fadeTimeout = setTimeout(() => {
this.element.css('display', 'none');
if (this.visible === false) {
this.element.css('display', 'none');
}
this.fadeTimeout = null;
}, FADE_TIMEOUT_MS);
};