maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[ML] Data Visualizer: error toast shows error text (#60682)

Browse source 
* dataviz searchbar:update error toast with full message

* update error toast title
This commit is contained in:
Melissa Alvarez 2020-03-20 13:04:08 -04:00 committed by GitHub
parent 22f14b53cd
commit c9cc04423d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
x-pack/plugins/ml/public/application/datavisualizer/index_based/components/search_panel/search_panel.tsx
View file

@ -56,20 +56,6 @@ const searchSizeOptions = [1000, 5000, 10000, 100000, -1].map(v => {
};
});
const kqlSyntaxErrorMessage = i18n.translate(
'xpack.ml.datavisualizer.invalidKqlSyntaxErrorMessage',
{
defaultMessage:
'Invalid syntax in search bar. The input must be valid Kibana Query Language (KQL)',
}
);
const luceneSyntaxErrorMessage = i18n.translate(
'xpack.ml.datavisualizer.invalidLuceneSyntaxErrorMessage',
{
defaultMessage: 'Invalid syntax in search bar. The input must be valid Lucene',
}
);
export const SearchPanel: FC<Props> = ({
indexPattern,
searchString,
@ -106,13 +92,14 @@ export const SearchPanel: FC<Props> = ({
setSearchString(query.query);
setSearchQueryLanguage(query.language);
} catch (e) {
console.log('Invalid syntax', e); // eslint-disable-line no-console
console.log('Invalid syntax', JSON.stringify(e, null, 2)); // eslint-disable-line no-console
const toastNotifications = getToastNotifications();
const notification =
query.language === SEARCH_QUERY_LANGUAGE.KUERY
? kqlSyntaxErrorMessage
: luceneSyntaxErrorMessage;
toastNotifications.addDanger(notification);
toastNotifications.addError(e, {
title: i18n.translate('xpack.ml.datavisualizer.invalidSyntaxErrorMessage', {
defaultMessage: 'Invalid syntax in search bar',
}),
toastMessage: e.message ? e.message : e,
});
}
};
const searchChangeHandler = (query: Query) => setSearchInput(query);