maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

don't memoize createCache, use >= for cache index walking

Browse source
This commit is contained in:
Joe Fleming 2015-02-05 11:16:07 -07:00
parent 38b90a65ec
commit c9ce4ad475
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/kibana/components/vislib/lib/data.js
View file

@ -127,7 +127,7 @@ define(function (require) {
/**
*
*/
Data.prototype._createCache = _.memoize(function () {
Data.prototype._createCache = function () {
var cache = {
index: {
chart: 0,
@ -140,7 +140,7 @@ define(function (require) {
cache.count = this._getCounts(cache.index.chart, cache.index.stack);
return cache;
});
};
/**
* Stacking function passed to the D3 Stack Layout `.out` API.
@ -162,7 +162,7 @@ define(function (require) {
// last stack, or last value, reset the stack count and y value array
var lastStack = (this._cache.index.stack === this._cache.count.stacks);
var lastStack = (this._cache.index.stack >= this._cache.count.stacks);
if (lastStack) {
this._cache.index.stack = 0;
++this._cache.index.value;
@ -173,13 +173,13 @@ define(function (require) {
}
// last value, prepare for the next chart, if one exists
var lastValue = (this._cache.index.value === this._cache.count.values);
var lastValue = (this._cache.index.value >= this._cache.count.values);
if (lastValue) {
this._cache.index.value = 0;
++this._cache.index.chart;
// no more charts, reset the queue and finish
if (this._cache.index.chart === this._cache.count.charts) {
if (this._cache.index.chart >= this._cache.count.charts) {
this._cache = this._createCache();
return;
}