maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[APM] Uses doc link service instead of ElasticDocsLink for linking dropped transaction spans (#110964) (#111315)

Browse source
This commit is contained in:
István Zoltán Szabó 2021-09-07 10:50:39 +02:00 committed by GitHub
parent b7014c9af5
commit c9e42c92ea
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
docs/development/core/public/kibana-plugin-core-public.doclinksstart.links.md
View file

@ -12,6 +12,7 @@ readonly links: {
readonly apm: {
readonly kibanaSettings: string;
readonly supportedServiceMaps: string;
readonly droppedTransactionSpans: string;
readonly upgrading: string;
readonly metaData: string;
};

2
src/core/public/doc_links/doc_links_service.ts
View file

@ -34,6 +34,7 @@ export class DocLinksService {
apm: {
kibanaSettings: `${KIBANA_DOCS}apm-settings-in-kibana.html`,
supportedServiceMaps: `${KIBANA_DOCS}service-maps.html#service-maps-supported`,
droppedTransactionSpans: `${APM_DOCS}get-started/${DOC_LINK_VERSION}/transaction-spans.html#dropped-spans`,
upgrading: `${APM_DOCS}server/${DOC_LINK_VERSION}/upgrading.html`,
metaData: `${APM_DOCS}get-started/${DOC_LINK_VERSION}/metadata.html`,
},
@ -463,6 +464,7 @@ export interface DocLinksStart {
readonly apm: {
readonly kibanaSettings: string;
readonly supportedServiceMaps: string;
readonly droppedTransactionSpans: string;
readonly upgrading: string;
readonly metaData: string;
};

1
src/core/public/public.api.md
View file

@ -477,6 +477,7 @@ export interface DocLinksStart {
readonly apm: {
readonly kibanaSettings: string;
readonly supportedServiceMaps: string;
readonly droppedTransactionSpans: string;
readonly upgrading: string;
readonly metaData: string;
};

13
x-pack/plugins/apm/public/components/app/transaction_details/waterfall_with_summary/waterfall_container/Waterfall/transaction_flyout/DroppedSpansWarning.tsx
View file

@ -5,17 +5,18 @@
* 2.0.
*/
import { EuiCallOut, EuiHorizontalRule } from '@elastic/eui';
import { EuiCallOut, EuiHorizontalRule, EuiLink } from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import React from 'react';
import { Transaction } from '../../../../../../../../typings/es_schemas/ui/transaction';
import { ElasticDocsLink } from '../../../../../../shared/Links/ElasticDocsLink';
import { useApmPluginContext } from '../../../../../../../context/apm_plugin/use_apm_plugin_context';
export function DroppedSpansWarning({
transactionDoc,
}: {
transactionDoc: Transaction;
}) {
const { docLinks } = useApmPluginContext().core;
const dropped = transactionDoc.transaction.span_count?.dropped;
if (!dropped) {
return null;
@ -32,18 +33,14 @@ export function DroppedSpansWarning({
values: { dropped },
}
)}{' '}
<ElasticDocsLink
section="/apm/get-started"
path="/transaction-spans.html#dropped-spans"
target="_blank"
>
<EuiLink href={docLinks.links.apm.droppedTransactionSpans}>
{i18n.translate(
'xpack.apm.transactionDetails.transFlyout.callout.learnMoreAboutDroppedSpansLinkText',
{
defaultMessage: 'Learn more about dropped spans.',
}
)}
</ElasticDocsLink>
</EuiLink>
</EuiCallOut>
<EuiHorizontalRule />
</React.Fragment>