maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[lens] perf: memoize onEvent handler to avoid unnecessary re-render (#68637)

Browse source 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This commit is contained in:
Marta Bondyra 2020-06-12 16:59:27 +02:00 committed by GitHub
parent fd740a68ff
commit cb2c90ca4b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 22 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

39
x-pack/plugins/lens/public/editor_frame_service/editor_frame/workspace_panel.tsx
View file

@ -4,7 +4,7 @@
* you may not use this file except in compliance with the Elastic License.
*/
import React, { useState, useEffect, useMemo, useContext } from 'react';
import React, { useState, useEffect, useMemo, useContext, useCallback } from 'react';
import { FormattedMessage } from '@kbn/i18n/react';
import { i18n } from '@kbn/i18n';
import {
@ -136,6 +136,26 @@ export function InnerWorkspacePanel({
framePublicAPI.filters,
]);
const onEvent = useCallback(
(event: ExpressionRendererEvent) => {
if (!plugins.uiActions) {
// ui actions not available, not handling event...
return;
}
if (isLensBrushEvent(event)) {
plugins.uiActions.getTrigger(VIS_EVENT_TO_TRIGGER[event.name]).exec({
data: event.data,
});
}
if (isLensFilterEvent(event)) {
plugins.uiActions.getTrigger(VIS_EVENT_TO_TRIGGER[event.name]).exec({
data: event.data,
});
}
},
[plugins.uiActions]
);
const autoRefreshFetch$ = useMemo(
() => plugins.data.query.timefilter.timefilter.getAutoRefreshFetch$(),
[plugins.data.query.timefilter.timefilter.getAutoRefreshFetch$]
@ -231,22 +251,7 @@ export function InnerWorkspacePanel({
padding="m"
expression={expression!}
reload$={autoRefreshFetch$}
onEvent={(event: ExpressionRendererEvent) => {
if (!plugins.uiActions) {
// ui actions not available, not handling event...
return;
}
if (isLensBrushEvent(event)) {
plugins.uiActions.getTrigger(VIS_EVENT_TO_TRIGGER[event.name]).exec({
data: event.data,
});
}
if (isLensFilterEvent(event)) {
plugins.uiActions.getTrigger(VIS_EVENT_TO_TRIGGER[event.name]).exec({
data: event.data,
});
}
}}
onEvent={onEvent}
renderError={(errorMessage?: string | null) => {
return (
<EuiFlexGroup direction="column" alignItems="center">