From cd5459a2a08318d536e3c2e3c2f2b3199e74a012 Mon Sep 17 00:00:00 2001 From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Date: Thu, 26 Aug 2021 12:43:35 -0400 Subject: [PATCH] [Home app] Fix `this` references (#110207) (#110244) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * [Home app] Fix `this` references * More readable if Co-authored-by: Alejandro Fernández Haro --- src/plugins/home/public/application/components/home.tsx | 4 ++-- test/functional/apps/home/_welcome.ts | 6 ++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/plugins/home/public/application/components/home.tsx b/src/plugins/home/public/application/components/home.tsx index 30439e5fa87e..0572d7b80f98 100644 --- a/src/plugins/home/public/application/components/home.tsx +++ b/src/plugins/home/public/application/components/home.tsx @@ -117,7 +117,7 @@ export class Home extends Component { return this.props.directories.find((directory) => directory.id === id); } - getFeaturesByCategory(category: FeatureCatalogueCategory) { + private getFeaturesByCategory(category: FeatureCatalogueCategory) { return this.props.directories .filter((directory) => directory.showOnHomePage && directory.category === category) .sort((directoryA, directoryB) => (directoryA.order ?? -1) - (directoryB.order ?? -1)); @@ -177,7 +177,7 @@ export class Home extends Component { private renderWelcome() { return ( this.skipWelcome()} urlBasePath={this.props.urlBasePath} telemetry={this.props.telemetry} /> diff --git a/test/functional/apps/home/_welcome.ts b/test/functional/apps/home/_welcome.ts index ec7e9759558d..e0fd1b5619dc 100644 --- a/test/functional/apps/home/_welcome.ts +++ b/test/functional/apps/home/_welcome.ts @@ -26,5 +26,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.common.navigateToUrl('home', undefined, { disableWelcomePrompt: false }); expect(await PageObjects.home.isWelcomeInterstitialDisplayed()).to.be(true); }); + + it('clicking on "Explore on my own" redirects to the "home" page', async () => { + await PageObjects.common.navigateToUrl('home', undefined, { disableWelcomePrompt: false }); + expect(await PageObjects.home.isWelcomeInterstitialDisplayed()).to.be(true); + await PageObjects.common.clickAndValidate('skipWelcomeScreen', 'homeApp'); + }); }); }