maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Stack monitoring] Fix clusters functional tests when react is enabled (#114982)

Browse source 
* Fix test subjects for overview page

* fix pathname matching
This commit is contained in:
Ester Martí Vilaseca 2021-10-14 15:57:27 +02:00 committed by GitHub
parent 586682a0c4
commit cdce98c8a3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
x-pack/plugins/monitoring/public/application/pages/cluster/overview_page.tsx
View file

@ -50,7 +50,7 @@ export const ClusterOverview: React.FC<{}> = () => {
{
id: 'clusterName',
label: clusters[0].cluster_name,
testSubj: 'clusterName',
testSubj: 'overviewTabsclusterName',
route: '/overview',
},
];

2
x-pack/plugins/monitoring/public/application/route_init.tsx
View file

@ -57,7 +57,7 @@ export const RouteInit: React.FC<RouteInitProps> = ({
// check if we need to redirect because of attempt at unsupported multi-cluster monitoring
const clusterSupported = cluster.isSupported || clusters.length === 1;
if (location.pathname !== 'home' && !clusterSupported) {
if (location.pathname !== '/home' && !clusterSupported) {
return <Redirect to="/home" />;
}
}

2
x-pack/plugins/monitoring/public/directives/main/index.html
View file

@ -299,7 +299,7 @@
</div>
<div ng-if="monitoringMain.inOverview" class="euiTabs" role="navigation">
<a class="euiTab" data-test-subj="clusterName">{{ pageData.cluster_name }}</a>
<a class="euiTab" data-test-subj="overviewTabsclusterName">{{ pageData.cluster_name }}</a>
</div>
<div ng-if="monitoringMain.inAlerts" class="euiTabs" role="navigation">

3
x-pack/test/functional/services/monitoring/cluster_overview.js
View file

@ -12,8 +12,7 @@ export function MonitoringClusterOverviewProvider({ getService }) {
const retry = getService('retry');
const SUBJ_CLUSTER_ALERTS = `clusterAlertsContainer`;
const SUBJ_CLUSTER_OVERVIEW = 'clusterOverviewContainer';
const SUBJ_CLUSTER_NAME = `${SUBJ_CLUSTER_OVERVIEW} > clusterName`;
const SUBJ_CLUSTER_NAME = `overviewTabsclusterName`;
const SUBJ_ES_PANEL = `clusterItemContainerElasticsearch`;
const SUBJ_ES_STATUS = `${SUBJ_ES_PANEL} > statusIcon`;