maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[ML] Adding missing job groups to recognizer wizard (#55392)

Browse source
This commit is contained in:
James Gowdy 2020-01-21 15:25:58 +00:00 committed by GitHub
parent be31198d21
commit ce286f543e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
x-pack/legacy/plugins/ml/public/application/jobs/new_job/recognize/page.tsx
View file

@ -77,6 +77,7 @@ export const Page: FC<PageProps> = ({ moduleId, existingGroupIds }) => {
const [kibanaObjects, setKibanaObjects] = useState<KibanaObjects>({});
const [saveState, setSaveState] = useState<SAVE_STATE>(SAVE_STATE.NOT_SAVED);
const [resultsUrl, setResultsUrl] = useState<string>('');
const [existingGroups, setExistingGroups] = useState(existingGroupIds);
// #endregion
const {
@ -109,6 +110,10 @@ export const Page: FC<PageProps> = ({ moduleId, existingGroupIds }) => {
setKibanaObjects(kibanaObjectsResult);
setSaveState(SAVE_STATE.NOT_SAVED);
// mix existing groups from the server with the groups used across all jobs in the module.
const moduleGroups = [...response.jobs.map(j => j.config.groups || [])].flat();
setExistingGroups([...new Set([...existingGroups, ...moduleGroups])]);
} catch (e) {
// eslint-disable-next-line no-console
console.error(e);
@ -222,6 +227,12 @@ export const Page: FC<PageProps> = ({ moduleId, existingGroupIds }) => {
...jobOverrides,
[job.job_id as string]: job,
});
if (job.groups !== undefined) {
// add newly added jobs to the list of existing groups
// for use when editing other jobs in the module
const groups = [...new Set([...existingGroups, ...job.groups])];
setExistingGroups(groups);
}
};
const isFormVisible = [SAVE_STATE.NOT_SAVED, SAVE_STATE.SAVING].includes(saveState);
@ -304,7 +315,7 @@ export const Page: FC<PageProps> = ({ moduleId, existingGroupIds }) => {
jobs={jobs}
jobPrefix={jobPrefix}
saveState={saveState}
existingGroupIds={existingGroupIds}
existingGroupIds={existingGroups}
jobOverrides={jobOverrides}
onJobOverridesChange={onJobOverridesChange}
/>