maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[ML] Fix table factory usage. (#52486)

Browse source 
Moves calling the table factory out of components to avoid instantiation on every render call. Note all of this is a workaround for our own typescript version of EuiInMemoryTable. Once the original table has been migrated to TS, we should be able to remove the custom code.
This commit is contained in:
Walter Rafelsberger 2019-12-09 12:48:08 +01:00 committed by GitHub
parent e9299092f0
commit cffb4dcea8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
x-pack/legacy/plugins/ml/public/application/overview/components/analytics_panel/table.tsx
View file

@ -26,6 +26,8 @@ import {
import { AnalyticsViewAction } from '../../../data_frame_analytics/pages/analytics_management/components/analytics_list/actions';
import { formatHumanReadableDateTimeSeconds } from '../../../util/date_utils';
const MlInMemoryTable = mlInMemoryTableFactory<DataFrameAnalyticsListRow>();
interface Props {
items: DataFrameAnalyticsListRow[];
}
@ -113,8 +115,6 @@ export const AnalyticsTable: FC<Props> = ({ items }) => {
},
};
const MlInMemoryTable = mlInMemoryTableFactory<DataFrameAnalyticsListRow>();
return (
<MlInMemoryTable
allowNeutralSort={false}

4
x-pack/legacy/plugins/ml/public/application/overview/components/anomaly_detection_panel/table.tsx
View file

@ -34,6 +34,8 @@ import { JobSelectorBadge } from '../../../components/job_selector/job_selector_
import { toLocaleString } from '../../../util/string_utils';
import { getSeverityColor } from '../../../../../common/util/anomaly_utils';
const MlInMemoryTable = mlInMemoryTableFactory<Group>();
// Used to pass on attribute names to table columns
export enum AnomalyDetectionListColumns {
id = 'id',
@ -195,8 +197,6 @@ export const AnomalyDetectionTable: FC<Props> = ({ items, jobsList, statsBarData
},
};
const MlInMemoryTable = mlInMemoryTableFactory<Group>();
return (
<Fragment>
<EuiFlexGroup alignItems="center" justifyContent="spaceBetween">

4
x-pack/legacy/plugins/transform/public/app/sections/transform_management/components/transform_list/expanded_row_preview_pane.tsx
View file

@ -22,6 +22,8 @@ import { ES_FIELD_TYPES } from '../../../../../../../../../../src/plugins/data/p
import { formatHumanReadableDateTimeSeconds } from '../../../../../../common/utils/date_utils';
import { transformTableFactory } from './transform_table';
const TransformTable = transformTableFactory<EsDoc>();
interface Props {
transformConfig: TransformPivotConfig;
}
@ -197,8 +199,6 @@ export const ExpandedRowPreviewPane: FC<Props> = ({ transformConfig }) => {
const transformTableLoading = previewData.length === 0 && isLoading === true;
const dataTestSubj = `transformPreviewTabContent${!transformTableLoading ? ' loaded' : ''}`;
const TransformTable = transformTableFactory<EsDoc>();
return (
<div data-test-subj={dataTestSubj}>
<TransformTable